Repository navigation
Accept a request S3 external ID that matches the configured default - #1482
Open
biglittlebigben wants to merge 2 commits into
Open
biglittlebigben wants to merge 2 commits into
biglittlebigben wants to merge 2 commits into
Conversation
When the request assume_role_external_id field is disallowed, a request that supplies the configured external ID is now accepted as long as its assume_role_arn is empty or matches the configured ARN. A request that sets an external ID logs at Info when its external ID or ARN differs from the configured default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
paulwe
approved these changes
Oct 24, 2026
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
|
AV-sync stats summary: view in run #40044533288 |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
boks1971
approved these changes
Oct 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
s3_allow_request_assume_role_external_idis false, a request that setsassume_role_external_idis no longer rejected if the ID equalss3_assume_role_external_idand the request'sassume_role_arnis empty or equalss3_assume_role_arn. Any other request-supplied external ID is still rejected.A request that sets an external ID now logs at Info when its external ID or ARN differs from the configured default.
pkg/config/storage.go: relaxed gate and Info logpkg/config/config_test.go: cases for a matching ID with the configured ARN (accepted), a matching ID with a different ARN (rejected), and a differing ID (rejected)🤖 Generated with Claude Code