Skip to content

chore: remove unused AdaptiveInterruptionDetector.updateOptions - #2557

Closed
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-adaptiveinterruptiondetector-u-1b3538
Closed

detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-adaptiveinterruptiondetector-u-1b3538

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Description

Removes the unused updateOptions method from AdaptiveInterruptionDetector,
along with the now-unreferenced ThrowsPromise import that only it used.

Changes Made

  • Removed AdaptiveInterruptionDetector.updateOptions (no production or test
    callers anywhere in the codebase; dead since introduction).
  • Removed the ThrowsPromise import, which was only used by the removed method.

Context

The updateOptions method on AdaptiveInterruptionDetector had no callers in
production code or tests. The stream.updateOptions calls in the interruption
tests invoke the separate InterruptionStreamBase.updateOptions method, not
the detector-level fan-out helper. The detector-level updateOptions was
never wired into any entry-point and had no historical callers removed - it
was dead from the day it was introduced.

History

Pre-Review Checklist

  • Build passes: All builds (lint, typecheck, tests) pass locally
  • AI-generated code reviewed: Removed unnecessary comments and ensured code quality
  • Changes explained: All changes are properly documented and justified above
  • Scope appropriate: All changes relate to the PR title, or explanations provided for why they're included
  • Video demo: N/A (dead code removal, no behavior change)

Testing

  • Automated tests added/updated (N/A: pure dead code removal)
  • All tests pass (pnpm vitest run on interruption + voice test suites: 71 tests across 8 files)
  • Make sure both restaurant_agent.ts and realtime_agent.ts work properly (N/A: no behavior change)

Additional Notes

Tool: Detail: Dead Code


Dead Code PRs can be configured here.

@detail-app
detail-app Bot requested a review from a team as a code owner September 22, 2026 00:26
@detail-app
detail-app Bot requested a review from lukasIO September 22, 2026 00:26
@changeset-bot

changeset-bot Bot commented Sep 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f2d4f10

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Devin Review: 1 flag

Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

Devin Review

@detail-app

detail-app Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

Closing this pull request because it has had no human activity in 30 days (since 2026-09-22) and was opened 30 days ago. Detail closes its pull requests once they are more than 30 days old and have had no human activity for 14 days.

If this change is still useful, reopen the pull request and Detail won't close it again. To keep a Detail pull request open, add the detail-keep-open label to it.

@detail-app detail-app Bot closed this Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant