Repository navigation
chore: remove unused AdaptiveInterruptionDetector.updateOptions - #2557
detail-app[bot] wants to merge 1 commit into
Conversation
|
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
|
Closing this pull request because it has had no human activity in 30 days (since 2026-09-22) and was opened 30 days ago. Detail closes its pull requests once they are more than 30 days old and have had no human activity for 14 days. If this change is still useful, reopen the pull request and Detail won't close it again. To keep a Detail pull request open, add the |
Description
Removes the unused
updateOptionsmethod fromAdaptiveInterruptionDetector,along with the now-unreferenced
ThrowsPromiseimport that only it used.Changes Made
AdaptiveInterruptionDetector.updateOptions(no production or testcallers anywhere in the codebase; dead since introduction).
ThrowsPromiseimport, which was only used by the removed method.Context
The
updateOptionsmethod onAdaptiveInterruptionDetectorhad no callers inproduction code or tests. The
stream.updateOptionscalls in the interruptiontests invoke the separate
InterruptionStreamBase.updateOptionsmethod, notthe detector-level fan-out helper. The detector-level
updateOptionswasnever wired into any entry-point and had no historical callers removed - it
was dead from the day it was introduced.
History
Pre-Review Checklist
Testing
pnpm vitest runon interruption + voice test suites: 71 tests across 8 files)restaurant_agent.tsandrealtime_agent.tswork properly (N/A: no behavior change)Additional Notes
Tool: Detail: Dead Code
Dead Code PRs can be configured here.