fix: leaked dev servers and truncated new READMEs - #28
Merged
Conversation
Two independent bugs, both found while running the benchmark suite.
dev_server.py spawned dev servers with shell=True but cleaned up with
process.terminate(), which only signals the shell. The dev server itself
survived the benchmark, holding its port and, for CLIs that use a lock
file, blocking every later run. Dev servers now start in their own
process group and cleanup signals the whole group.
build_app_readme.py had a misparenthesized ternary in the create-new-file
path:
f"{sections['real_world_app']}\n\n" if sections['real_world_app'] else ""
"<!-- start_framework_specific -->\n\n"
The conditional binds to the whole expression, so the trailing literals
became part of the else branch. Any newly created README silently lost
its framework-specific block and its entire license footer. Existing
READMEs were unaffected, which is why this went unnoticed.
github-actions Bot
pushed a commit
to sathvikc/framework-benchmarks
that referenced
this pull request
Jul 26, 2026
github-actions Bot
pushed a commit
to nigrosimone/framework-benchmarks
that referenced
this pull request
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small bugs I ran into while benchmarking locally. Unrelated to each other, but both one-liners in spirit, so I've kept them together.
Dev servers were surviving the benchmark.
dev_server.pystarts them withshell=True, then cleans up withprocess.terminate(). That only signals the shell, so the dev server itself carries on running and holds its port. Most of the time you just end up with an orphan process, but any CLI that writes a lock file will then refuse to start on the next run. They now get their own process group, and cleanup signals the group.New app READMEs were coming out truncated. There's a misparenthesized ternary in the create-a-new-file path of
build_app_readme.py:The conditional binds to the whole expression, so everything after it becomes part of the
elsebranch. A freshly generated README silently loses its framework specific block and the entire license footer. Existing READMEs go down the update path instead, which is why this has never shown up.Tested locally, and I ran the Lint and Test workflows on my fork against this branch, both passing.