Skip to content

The data type for the finishing method is modified #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sleon4 merged 2 commits into from
Sep 6, 2025
Merged

The data type for the finishing method is modified #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fab1024
refactor: the data type for the finishing method is modified
Sleon4 Sep 6, 2025
a8f6d3a
test: coverage tests are added
Sleon4 Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/LionRequest/Response.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ public static function getErrors(): array
* @param mixed $response Message or content to view.
* @param bool $isJson Determines with a boolean if it is a JSON object.
*
* @return void
* @return never
*
* @codeCoverageIgnore
*/
public static function finish(mixed $response, bool $isJson = true): void
public static function finish(mixed $response, bool $isJson = true): never
{
die($isJson ? json_encode($response) : $response);
}
Expand Down
7 changes: 0 additions & 7 deletions tests/ResponseTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
use Lion\Request\Status;
use Lion\Test\Test;
use PHPUnit\Framework\Attributes\Test as Testing;
use stdClass;

class ResponseTest extends Test
{
Expand Down Expand Up @@ -44,7 +43,6 @@ public function response(): void
$res = $this->response->custom('custom');

$this->assertSame(Http::OK, http_response_code());
$this->assertInstanceOf(stdClass::class, $res);
$this->assertObjectHasProperty('status', $res);
$this->assertObjectHasProperty('message', $res);
$this->assertObjectHasProperty('code', $res);
Expand All @@ -59,7 +57,6 @@ public function responseWithData(): void
$res = $this->response->custom('custom', null, Http::OK, ['package' => 'request']);

$this->assertSame(Http::OK, http_response_code());
$this->assertInstanceOf(stdClass::class, $res);
$this->assertObjectHasProperty('status', $res);
$this->assertObjectHasProperty('message', $res);
$this->assertObjectHasProperty('code', $res);
Expand All @@ -76,7 +73,6 @@ public function success(): void
$res = $this->response->success(null, Http::OK, ['package' => 'request']);

$this->assertSame(Http::OK, http_response_code());
$this->assertInstanceOf(stdClass::class, $res);
$this->assertObjectHasProperty('status', $res);
$this->assertObjectHasProperty('message', $res);
$this->assertObjectHasProperty('code', $res);
Expand All @@ -93,7 +89,6 @@ public function error(): void
$res = $this->response->error(null, Http::INTERNAL_SERVER_ERROR, ['package' => 'request']);

$this->assertSame(Http::INTERNAL_SERVER_ERROR, http_response_code());
$this->assertInstanceOf(stdClass::class, $res);
$this->assertObjectHasProperty('status', $res);
$this->assertObjectHasProperty('message', $res);
$this->assertObjectHasProperty('code', $res);
Expand All @@ -110,7 +105,6 @@ public function warning(): void
$res = $this->response->warning(null, Http::OK, ['package' => 'request']);

$this->assertSame(Http::OK, http_response_code());
$this->assertInstanceOf(stdClass::class, $res);
$this->assertObjectHasProperty('status', $res);
$this->assertObjectHasProperty('message', $res);
$this->assertObjectHasProperty('code', $res);
Expand All @@ -127,7 +121,6 @@ public function info(): void
$res = $this->response->info(null, Http::OK, ['package' => 'request']);

$this->assertSame(Http::OK, http_response_code());
$this->assertInstanceOf(stdClass::class, $res);
$this->assertObjectHasProperty('status', $res);
$this->assertObjectHasProperty('message', $res);
$this->assertObjectHasProperty('code', $res);
Expand Down
Loading