P2p sidecar - #39
Open
aptalca wants to merge 3 commits into
Open
P2p sidecar#39aptalca wants to merge 3 commits into
aptalca wants to merge 3 commits into
Conversation
mStream 6.21+ fetches its p2p discovery sidecar binary on first use, sha256-verified against a manifest committed in the app tree. Baking it at image build (the app ships a script for exactly this) means discovery works in containers with no runtime egress to github.com and with no first-enable download; the fetch is pinned+verified either way, and images inherit new pins on their normal rebuilds. Runtime fetch remains as the fallback for anything else, so nothing breaks for older images. Verified: built the x86_64 image, then in a --network none container the baked binary executes (--print-id returns a valid node id) as user abc. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Bake the p2p discovery sidecar into the image at build time
Contributor
|
I am a bot, here are the test results for this PR for commit f369ceb :
|
Contributor
|
I am a bot, here are the test results for this PR for commit a23cc40 :
|
thespad
approved these changes
Sep 20, 2026
github-project-automation
Bot
moved this from PRs Ready For Team Review
to PRs Approved
in Issue & PR Tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#37 redo for ci tests