Repository navigation
Conversation
…tdown When the session enters CSM_MANAGER_PHASE_END_SESSION or CSM_MANAGER_PHASE_EXIT, applications terminate from signals (SIGTERM/SIGHUP). Previously, app_died() and app_exited() would attempt to restart dying components, triggering redundant phase transitions and repeatedly calling csm_manager_quit(). This patch: 1. Adds an is_quitting guard in CsmManagerPrivate to ensure csm_manager_quit() is executed only once. 2. Skips app restarts in app_died() and app_exited() once the session is in END_SESSION/EXIT phase or is_quitting. 3. Guards request_reboot(), request_shutdown(), and request_logout() against re-entry if a shutdown sequence is already in progress. 4. Ensures systemduserunitdir installs into prefix when prefix is not /usr.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the session enters
CSM_MANAGER_PHASE_END_SESSIONorCSM_MANAGER_PHASE_EXIT(particularly noticeable under Wayland sessions during logout or power off), client applications terminate upon receiving signals (SIGTERM/SIGHUP). Previously,app_died()andapp_exited()would attempt to restart dying components, triggering redundant phase transitions and repeatedly callingcsm_manager_quit().Changes
is_quittingflag inCsmManagerPrivateto ensurecsm_manager_quit()executes only once.app_died()andapp_exited()once the session is inEND_SESSION/EXITphase oris_quitting.request_reboot(),request_shutdown(), andrequest_logout()against re-entry if a shutdown sequence is already in progress.systemduserunitdirdefaults to prefix when prefix is not/usr.