Skip to content

fix: restore concurrent transfer check in rpc handler #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pppanghu77 wants to merge 1 commit into
base: release/v20
Choose a base branch
from
+1 −1
Draft

fix: restore concurrent transfer check in rpc handler #836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/daemon/core/service/rpc/handlerpcservice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ bool HandleRpcService::handleRemoteLogin(co::Json &info)
JobManager::instance()->confirmTransfer(lo.appName.c_str());
}
}
bool statu = true;//Comshare::instance()->checkTransCanConnect();
bool statu = Comshare::instance()->checkTransCanConnect();

@sourcery-ai sourcery-ai Bot Oct 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High · Rejected logins still connect

When authentication succeeds while checkTransCanConnect() returns false, handleRemoteLogin rejects the RPC login but passes authOK alone to handleRpcLogin; that handler creates a sender, updates connection state, and reports success to the local frontend, so the caller sees a successful connection for a rejected login.

Use authOK && statu as the admission result passed to handleRpcLogin and use it to prevent rejected logins from establishing connection state.

Prompt for AI agents 
In `src/plugins/daemon/core/service/rpc/handlerpcservice.cpp` at line 141:

**Rejected logins still connect**

When authentication succeeds while `checkTransCanConnect()` returns false, `handleRemoteLogin` rejects the RPC login but passes `authOK` alone to `handleRpcLogin`; that handler creates a sender, updates connection state, and reports success to the local frontend, so the caller sees a successful connection for a rejected login.

Use `authOK && statu` as the admission result passed to `handleRpcLogin` and use it to prevent rejected logins from establishing connection state.

if (!authOK || !statu) {
lores.result = false;
lores.token = authOK ? "connect file status error!" : "Invalid auth code";
Expand Down
Loading