Repository navigation
fix: wrap device nickname tooltip with max-width - #835
Draft
pppanghu77 wants to merge 37 commits into
Draft
pppanghu77 wants to merge 37 commits into
pppanghu77 wants to merge 37 commits into
Conversation
add avahi discover Log: add avahi discover Task: https://pms.uniontech.com/task-view-354339.html
[build] fix build Log: [build] fix build Task: https://pms.uniontech.com/task-view-354339.html
new tag v0.8.5, fix frontend launch issue for win. Log: v0.8.5 override other incompatible version.
fix Multi user startup test Log: fix Multi user startup test Bug: https://pms.uniontech.com/bug-view-256723.html
add tip translation Log: add tip translation Bug: https://pms.uniontech.com/bug-view-260533.html
[start] Change the startup sequence of the front-end and back-end Log: [start] Change the startup sequence of the front-end and back-end Bug: https://pms.uniontech.com/bug-view-261983.html
new tag v0.8.6 Log: new tag v0.8.6
[translation] add bo ug translation Log: [translation] add bo ug translation
Fix title icon issue which caused by DTK updated. Log: Fix title icon issue. Bug: https://pms.uniontech.com/bug-view-264627.html
v0.8.7 release. Log: v0.8.7 release.
…offline Avoiding the impact of network fluctuations Log: Added the option to manually disconnect the other party offline Task: https://pms.uniontech.com/task-view-357177.html
Fix List Status and move the log location to/etc Log: Fix List Status and move the log location to/et Task: https://pms.uniontech.com/task-view-357177.html
v0.8.8 release. Log: v0.8.8 release.
Modify the storage location of log level files Log: Modify the storage location of log level files Task: https://pms.uniontech.com/story-view-36529.html
Fix translation and UI issues Log: Fix translation and UI issues Bug: https://pms.uniontech.com/bug-view-250549.html
libcoost creates persistent static resources for each thread, which can cause memory leaks when threads are frequently created and released using a thread pool to avoid frequent creation and destruction of threads Log: Fix memory leaks Bug: https://pms.uniontech.com/bug-view-266935.html
The daemon is renamed dde operation daemon Log: The daemon is renamed dde operation daemon Bug: https://pms.uniontech.com/bug-view-266935.html
v0.8.9 release. Log: v0.8.9 release.
The default number of thread pools is too low, resulting in communication failure Log: [thread] Increase the initial number of threads in threadpool Bug: https://pms.uniontech.com/bug-view-273695.html
…nnection Fix the issue of disconnection after network disconnection Log: Fix the issue of disconnection after network disconnection Bug: https://pms.uniontech.com/bug-view-273833.html
Record the searched devices and provide the option to minimize pallets Log: [optimization] Optimize user experience Bug: https://pms.uniontech.com/bug-view-250143.html
fix ui bug Log: fix ui bug Bug: https://pms.uniontech.com/bug-view-256019.html
fix the password for the connection page is not complete in tibetan Log: fix the password display is incomplete Bug: https://pms.uniontech.com/bug-view-250623.html
Probability crash upon awakening Log: Probability crash upon awakening Bug: no
Unable to open from launcher after closing Log: fix some ui bug Bug: https://pms.uniontech.com/bug-view-282501.html
Implement a check in the setFile function to ensure that file paths do not exceed two directory levels. This change modifies the filename to retain only the last two directories and the file name itself, enhancing path management. Log: Filter file paths to limit depth to two directories.
…P retrieval Replace direct usage of QNetworkInterface::allAddresses() with deepin_cross::CommonUitls::getFirstIp() to get the first available IP address. Log: fix: (data-transfer) replace QNetworkInterface with CommonUtils for IP retrieval Bug: https://pms.uniontech.com/bug-view-341249.html
…rm transfer mechanism - Add security checks in `getSaveFullpath` to prevent path traversal attacks by validating filenames and ensuring they are within allowed directories using realpath resolution. - Introduce transfer confirmation mechanism in `JobManager` to require user approval before accepting incoming file transfers. - Add methods to confirm, remove, and check transfer confirmation status for apps. - Update `SendRpcService` to handle transfer confirmation and refusal messages. - Include cleanup of confirmation status when jobs finish, cancel, or fail. Log: fix(security): add path traversal protection in TransferJob and confirm transfer mechanism Bug: https://pms.uniontech.com/bug-view-343709.html
Replace the library's dependencies with a method that displays the calling dynamic library. Log: Remove displayjack kvm depend.
- Add file transfer confirmation status when password authentication succeeds - Allow subsequent file transfers by calling JobManager::confirmTransfer - This enables file operations after remote login is authenticated Log: fix(rpc): add file transfer confirmation after successful authentication Bug: https://pms.uniontech.com/bug-view-354299.html
- Remove the transfer confirmation cleanup on job finished/canceled/failed - Keep the confirmation state alive for the entire session to allow subsequent transfers without re-authentication - This fixes the network error when transferring files again after returning from a completed transfer Log: fix(transfer): 传输完成后点击返回再次传输提示网络错误 Bug: https://pms.uniontech.com/bug-view-355819.html
…emove transfer.json - Fix storage directory for data-transfer: place target subdirectory under ~/Downloads instead of directly under home directory - Change cleanup behavior to only remove transfer.json instead of the entire directory Log: fix(data-transfer): save files to ~/Downloads subdirectory and only remove transfer.json Bug: https://pms.uniontech.com/bug-view-356089.html
sync by github workflow Log: none Influence: none
… prompt on app installation - Add initSecurityLoaderReport() in main.cpp: when started by deepin-security-loader (--fd1/--fd2 passed), report the system bus unique name and the com.deepin.lastore service list to the loader in JSON so it registers the lastore allow-caller whitelist on our behalf, making InstallPackage free of polkit authentication - Call the report before any early-exit branch (including single-instance failure), otherwise the loader times out and kills the process, which shows up as a crash on startup - Add launcher script /usr/bin/deepin-data-transfer: start the real binary /usr/libexec/deepin/deepin-data-transfer through deepin-security-loader with the deepin-daemon group when available (dbus >= 1.12.20.17-deepin1), otherwise fall back to direct launch with the historical polkit behavior - Enable Qt DBus component/linking and install the real binary to libexec/deepin with the launcher taking over /usr/bin - Update debian packaging: install the libexec binary and add Recommends: deepin-security-loader 修复(data-transfer): 经 deepin-security-loader 启动以避免安装应用时弹出 polkit 鉴权框 - main.cpp 新增 initSecurityLoaderReport()：经 deepin-security-loader 启动（带 --fd1/--fd2 参数）时，将 system bus 唯一连接名和 com.deepin.lastore 服务列表以 JSON 回报给 loader，由其代为注册 lastore 的 allow-caller 白名单，使 InstallPackage 等接口免 polkit 鉴权 - 回报调用置于任何提前退出分支（含单例失败）之前，否则 loader 会超时结束子进程，表现为启动闪退 - 新增启动脚本 /usr/bin/deepin-data-transfer：环境满足（dbus >= 1.12.20.17-deepin1）时经 deepin-security-loader 附加 deepin-daemon 组启动真实二进制 /usr/libexec/deepin/deepin-data-transfer，否则回退直接启动，鉴权行为与历史一致 - 启用 Qt DBus 组件与链接，真实二进制安装至 libexec/deepin，/usr/bin 由启动脚本接管 - 更新 debian 打包：安装 libexec 二进制并增加 Recommends: deepin-security-loader Log: 数据迁移工具经 deepin-security-loader 附加 deepin-daemon 组启动并回报 bus 连接名，实现 lastore 安装接口免鉴权，修复迁移三方应用时弹出密码认证框的问题 Bug: https://pms.uniontech.com/bug-view-375325.html
…n different filesystems - Move directories with QDir::rename instead of QFile::rename, which fails with EISDIR on directories - Fall back to recursive copy plus source removal when rename fails with EXDEV across filesystems: copyDirectory() for directories and QFile::copy for single files - Fix rename-collision handling: dst.remove(fileName) deleted every occurrence of the name and corrupted paths with repeated segments; only the trailing segment is cut now - Ensure the destination parent directory exists before moving, for targets such as ~/D:/ derived from Windows drive letters 修复(数据迁移): 修复源和目标位于不同文件系统时 moveFile 搬运失败的问题 - 目录改用 QDir::rename 移动，避免 QFile::rename 移动目录时报 EISDIR 错误 - rename 跨文件系统失败(EXDEV)时退化为复制后删除源：目录走 copyDirectory() 递归复制，单文件走 QFile::copy - 修复重名避让逻辑: dst.remove(fileName) 会误删路径中所有同名段导致路径破坏，改为只截取结尾段 - 移动前确保目标父目录存在，兼容 ~/D:/ 这类源自 Windows 盘符的目标路径 Log: 修复数据迁移搬运阶段接收目录与主目录不在同一文件系统时 rename 跨设备失败(EXDEV)导致搬运失败的问题 Bug: https://pms.uniontech.com/bug-view-375881.html
- In domain-account environments the loginctl session username may differ from the home directory name (e.g. "@xxx"), and the name comparison failed, making the daemon exit right after startup (inactive desktop session) - isActiveUser() now compares the active desktop session UID against getuid(), decoupled from the user naming scheme; when multiple desktop sessions are active, only the one belonging to the current user is taken as the active session - KEY_CURRENT_ACTIVE_USER now stores the active session UID and the ServiceManager runtime check compares UIDs accordingly - Guard the loginctl/getuid() based session check with _WIN32 so the daemon still compiles on Windows, where the check is not applicable - Update SPDX copyright year to 2023-2026 for the modified files 修复(daemon): 改用 UID 而非用户名判定活动桌面会话 - 域账号场景下 loginctl 会话用户名与家目录名可能不一致(如 "@xxx"), 名字比对失败导致 daemon 启动即退出(exit, inactive desktop session) - isActiveUser 改为比对活动桌面会话 UID 与 getuid(), 与命名体系解耦; 存在多个活跃桌面会话时, 以属于当前用户的会话为准 - KEY_CURRENT_ACTIVE_USER 改存活动会话 UID, ServiceManager 运行时检查同步按 UID 判定 - 活动会话检查增加 _WIN32 平台守卫, 修复 Windows 构建下 getuid() 编译失败的问题 - 更新所改文件的 SPDX 版权年份为 2023-2026 Log: 修复域账号环境下跨端协同 daemon 无法启动的问题
pppanghu77
marked this pull request as draft
October 29, 2026 19:00
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pppanghu77 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
TAG Bot TAG: 0.8.9 |
1. Root cause: DeviceItem::setDeviceName set plain text tooltip via setToolTip(name), Qt renders plain text tooltips as single line 2. Fix: use rich text tooltip with CSS white-space:pre-wrap and max-width constraint, HTML-escape nickname for safety 3. Impact: long nicknames now wrap within 400px tooltip window, no behavior change for short names Log: Fix device nickname tooltip unreadable when name is long Influence: 1. Test tooltip display with short nickname (no tooltip expected) 2. Test tooltip display with long nickname (wraps within 400px) 3. Verify tooltip on high-DPI displays does not exceed screen width fix: 修复设备昵称过长时提示看不清的问题 1. 根因：DeviceItem::setDeviceName 使用 setToolTip(name) 设置纯文本 提示，Qt 将纯文本 tooltip 渲染为单行，长昵称超出屏幕宽度 2. 方案：改用富文本 tooltip，添加 CSS white-space:pre-wrap 和 max-width 约束，并对昵称做 HTML 转义 3. 影响：长昵称在 400px 宽度内自动换行显示，短昵称无行为变化 Log: 修复设备昵称过长时 hover 提示看不清的问题 Influence: 1. 测试短昵称时 tooltip 不显示（名称未截断） 2. 测试长昵称时 tooltip 自动换行且不超出屏幕 3. 验证高 DPI 屏幕上 tooltip 显示正常 Bug: #250695
pppanghu77
force-pushed
the
agent/agent/bbe73fdfbc9f
branch
from
October 29, 2026 20:34
653fd79 to
606c4bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause Analysis
DeviceItem::setDeviceName() sets a plain text tooltip via setToolTip(name). Qt renders plain text tooltips as a single line without wrapping. When a device nickname is long (e.g., 82 characters), the tooltip width reaches 788px, exceeding the visible area on Windows high-DPI displays. Key evidence: deviceitem.cpp:166 originally calls setToolTip(name) with plain text; Qt documentation confirms plain text tooltips do not auto-wrap.
Fix Approach
Replace the plain text tooltip with a rich text (HTML) tooltip that includes CSS
white-space: pre-wrap; max-width: 400px;to constrain width and enable wrapping. The nickname is HTML-escaped via toHtmlEscaped() to prevent injection. This matches the analysis report's recommended fix.Change Safety Assessment
Code Safety
setToolTip(name)was introduced in commit 3ea45cb (UI optimization, not a bug fix), so this change does not revert any historical fixDeviceItem::setDeviceInfoat deviceitem.cpp:98; change affects only tooltip rendering (plain text → rich text), no signature or call logic changeBusiness Impact Scope
Affected module: cross-device cooperation device list display, specifically device nickname tooltip. User scenario: hovering over a device with a long nickname now shows a wrapped tooltip within 400px instead of an unreadable single-line tooltip exceeding the screen.
Verification Suggestion
Verify long nickname tooltip wraps correctly within 400px, short nicknames show no tooltip (showName == name), and nicknames with HTML special characters (<, >, &) display correctly after escaping.
根因分析
DeviceItem::setDeviceName() 使用 setToolTip(name) 设置纯文本 tooltip，Qt 将纯文本 tooltip 渲染为单行不换行。当设备昵称较长（如 82 字符）时，tooltip 单行宽度达 788px，在 Windows 高 DPI 屏幕上超出可视区域。关键证据：deviceitem.cpp:166 原始代码 setToolTip(name) 传入纯文本，Qt 文档明确纯文本 tooltip 不自动换行。
修复方案
将 setToolTip 的参数从纯文本改为富文本（HTML），添加 CSS
white-space: pre-wrap; max-width: 400px;约束使 tooltip 在 400px 宽度内自动换行，同时对昵称调用 toHtmlEscaped() 防止 HTML 注入。与分析报告建议方案一致。改动安全评估
代码安全评估
setToolTip(name)于 commit 3ea45cb（UI 优化）引入，非 bug 修复产物，本次改动不撤销任何历史修复业务影响范围
受影响模块：跨端协同设备列表显示，具体为设备昵称 tooltip 提示。用户场景：鼠标悬停长昵称设备时 tooltip 在 400px 内自动换行显示完整昵称，不再超出屏幕。
验证建议
验证长昵称 tooltip 在 400px 内换行可读，短昵称无 tooltip 弹出，含 HTML 特殊字符昵称正确转义显示。
PMS: BUG-250695