ALSA: fireworks: fix memory leak of response buffer at error path

takaswie · gregkh · commit d9929097176d · 2018-09-29T03:06:03.000-07:00
commit c3b55e2 upstream. After allocating memory object for response buffer, ALSA fireworks driver has leak of the memory object at error path. This commit releases the object at the error path. Fixes: 7d3c1d5('ALSA: fireworks: delayed registration of sound card') Cc: <stable@vger.kernel.org> # v4.7+ Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/sound/firewire/fireworks/fireworks.c b/sound/firewire/fireworks/fireworks.c
@@ -301,6 +301,8 @@ do_registration(struct work_struct *work)
 	snd_efw_transaction_remove_instance(efw);
 	snd_efw_stream_destroy_duplex(efw);
 	snd_card_free(efw->card);
+	kfree(efw->resp_buf);
+	efw->resp_buf = NULL;
 	dev_info(&efw->unit->device,
 		 "Sound card registration failed: %d\n", err);
 }

Original file line number	Diff line number	Diff line change
`@@ -301,6 +301,8 @@ do_registration(struct work_struct *work)`
`301`	`301`	`snd_efw_transaction_remove_instance(efw);`
`302`	`302`	`snd_efw_stream_destroy_duplex(efw);`
`303`	`303`	`snd_card_free(efw->card);`
	`304`	`+ kfree(efw->resp_buf);`
	`305`	`+ efw->resp_buf = NULL;`
`304`	`306`	`dev_info(&efw->unit->device,`
`305`	`307`	`"Sound card registration failed: %d\n", err);`
`306`	`308`	`}`