ALSA: firewire-tascam: fix memory leak of private data

takaswie · gregkh · commit 40e2596f06b0 · 2018-09-29T03:06:02.000-07:00
commit 8d28277 upstream. Although private data of sound card instance is usually allocated in the tail of the instance, drivers in ALSA firewire stack allocate the private data before allocating the instance. In this case, the private data should be released explicitly at .private_free callback of the instance. This commit fixes memory leak following to the above design. Fixes: b610386 ('ALSA: firewire-tascam: deleyed registration of sound card') Cc: <stable@vger.kernel.org> # v4.7+ Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/sound/firewire/tascam/tascam.c b/sound/firewire/tascam/tascam.c
@@ -93,6 +93,7 @@ static void tscm_free(struct snd_tscm *tscm)
 	fw_unit_put(tscm->unit);
 
 	mutex_destroy(&tscm->mutex);
+	kfree(tscm);
 }
 
 static void tscm_card_free(struct snd_card *card)

Original file line number	Diff line number	Diff line change
`@@ -93,6 +93,7 @@ static void tscm_free(struct snd_tscm *tscm)`
`93`	`93`	`fw_unit_put(tscm->unit);`
`94`	`94`
`95`	`95`	`mutex_destroy(&tscm->mutex);`
	`96`	`+ kfree(tscm);`
`96`	`97`	`}`
`97`	`98`
`98`	`99`	`static void tscm_card_free(struct snd_card *card)`