Skip to content

Commit c8c2df1

Browse files
ffainelligregkh
authored andcommitted
net: bcmgenet: Poll internal PHY for GENETv5
[ Upstream commit 64bd9c8 ] On GENETv5, there is a hardware issue which prevents the GENET hardware from generating a link UP interrupt when the link is operating at 10Mbits/sec. Since we do not have any way to configure the link detection logic, fallback to polling in that case. Fixes: 4213808 ("net: bcmgenet: add support for the GENETv5 hardware") Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 71944eb commit c8c2df1

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

  • drivers/net/ethernet/broadcom/genet

drivers/net/ethernet/broadcom/genet/bcmmii.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -339,9 +339,12 @@ int bcmgenet_mii_probe(struct net_device *dev)
339339
phydev->advertising = phydev->supported;
340340

341341
/* The internal PHY has its link interrupts routed to the
342-
* Ethernet MAC ISRs
343-
*/
344-
if (priv->internal_phy)
342+
* Ethernet MAC ISRs. On GENETv5 there is a hardware issue
343+
* that prevents the signaling of link UP interrupts when
344+
* the link operates at 10Mbps, so fallback to polling for
345+
* those versions of GENET.
346+
*/
347+
if (priv->internal_phy && !GENET_IS_V5(priv))
345348
priv->phydev->irq = PHY_IGNORE_INTERRUPT;
346349

347350
return 0;

0 commit comments

Comments
 (0)