Skip to content

Commit 71944eb

Browse files
Nikolay Aleksandrovgregkh
authored andcommitted
net: ipmr: fix unresolved entry dumps
[ Upstream commit eddf016 ] If the skb space ends in an unresolved entry while dumping we'll miss some unresolved entries. The reason is due to zeroing the entry counter between dumping resolved and unresolved mfc entries. We should just keep counting until the whole table is dumped and zero when we move to the next as we have a separate table counter. Reported-by: Colin Ian King <colin.king@canonical.com> Fixes: 8fb472c ("ipmr: improve hash scalability") Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 4ca72d6 commit 71944eb

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

net/ipv4/ipmr.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2499,8 +2499,6 @@ static int ipmr_rtm_dumproute(struct sk_buff *skb, struct netlink_callback *cb)
24992499
next_entry:
25002500
e++;
25012501
}
2502-
e = 0;
2503-
s_e = 0;
25042502

25052503
spin_lock_bh(&mfc_unres_lock);
25062504
list_for_each_entry(mfc, &mrt->mfc_unres_queue, list) {

0 commit comments

Comments
 (0)