net: dsa: return after vlan prepare phase

vivien · davem330 · commit 2118df93b5e1 · 2017-11-11T15:45:09.000+09:00
The current code does not return after successfully preparing the VLAN addition on every ports member of a it. Fix this. Fixes: 1ca4aa9 ("net: dsa: check VLAN capability of every switch") Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/dsa/switch.c b/net/dsa/switch.c
@@ -182,6 +182,8 @@ static int dsa_switch_vlan_add(struct dsa_switch *ds,
 			if (err)
 				return err;
 		}
+
+		return 0;
 	}
 
 	for_each_set_bit(port, members, ds->num_ports)

Original file line number	Diff line number	Diff line change
`@@ -182,6 +182,8 @@ static int dsa_switch_vlan_add(struct dsa_switch *ds,`
`182`	`182`	`if (err)`
`183`	`183`	`return err;`
`184`	`184`	`}`
	`185`	`+`
	`186`	`+ return 0;`
`185`	`187`	`}`
`186`	`188`
`187`	`189`	`for_each_set_bit(port, members, ds->num_ports)`