net: dsa: return after mdb prepare phase

vivien · davem330 · commit b0b38a1c6684 · 2017-11-11T15:45:09.000+09:00
The current code does not return after successfully preparing the MDB addition on every ports member of a multicast group. Fix this. Fixes: a1a6b7e ("net: dsa: add cross-chip multicast support") Reported-by: Egil Hjelmeland <privat@egil-hjelmeland.no> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/dsa/switch.c b/net/dsa/switch.c
@@ -133,6 +133,8 @@ static int dsa_switch_mdb_add(struct dsa_switch *ds,
 			if (err)
 				return err;
 		}
+
+		return 0;
 	}
 
 	for_each_set_bit(port, group, ds->num_ports)

Original file line number	Diff line number	Diff line change
`@@ -133,6 +133,8 @@ static int dsa_switch_mdb_add(struct dsa_switch *ds,`
`133`	`133`	`if (err)`
`134`	`134`	`return err;`
`135`	`135`	`}`
	`136`	`+`
	`137`	`+ return 0;`
`136`	`138`	`}`
`137`	`139`
`138`	`140`	`for_each_set_bit(port, group, ds->num_ports)`