ci: Add config file for CodeRabbit with custom rules#189
Merged
Conversation
Sourcery that we currently use cannot read documentation files and best practices, it's rather a refactoring tool. So I want to introduce CodeRabbit that allows creating .coderabbit.yaml with custom rules and conventions. Signed-off-by: Sergei Petrosian <spetrosi@redhat.com>
Reviewer's Guide.coderabbit.yaml is introduced to configure CodeRabbit code review automation with project-specific review rules, PR conventions, and path-based guidance for Ansible roles, tests, templates, variables, Python code, and documentation, while disabling non-essential AI assistant features. Sequence diagram for CodeRabbit review using .coderabbit.yamlsequenceDiagram
actor Developer
participant GitHub
participant CodeRabbit
participant Repo
Developer->>GitHub: Open_pull_request
GitHub->>Repo: Load_coderabbit_yaml
GitHub->>CodeRabbit: Trigger_review_with_config
CodeRabbit->>Repo: Analyze_changes
CodeRabbit->>CodeRabbit: Apply_pre_merge_checks
CodeRabbit->>CodeRabbit: Apply_path_instructions
CodeRabbit-->>GitHub: Post_review_comments
GitHub-->>Developer: Display_CodeRabbit_review
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Several instructions (e.g.,
postgresql_secure_logging,__postgresql_is_ostree,system_role:postgresql, andpostgresql_variable prefixes) are very role-specific while the header describes this as a generic linux-system-roles config; consider either generalizing these names or clearly scoping this config to the postgresql role to avoid confusing reviewers on other roles. - The note in
defaults/**/*.ymlthat “Ansible doesn't include variables from other files” is misleading, since Ansible does load multiple files underdefaults/; it would be clearer to explain that this project’s convention is to keep all user-facing defaults indefaults/main.ymlrather than implying Ansible cannot use other defaults files.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Several instructions (e.g., `postgresql_secure_logging`, `__postgresql_is_ostree`, `system_role:postgresql`, and `postgresql_` variable prefixes) are very role-specific while the header describes this as a generic linux-system-roles config; consider either generalizing these names or clearly scoping this config to the postgresql role to avoid confusing reviewers on other roles.
- The note in `defaults/**/*.yml` that “Ansible doesn't include variables from other files” is misleading, since Ansible does load multiple files under `defaults/`; it would be clearer to explain that this project’s convention is to keep all user-facing defaults in `defaults/main.yml` rather than implying Ansible cannot use other defaults files.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sourcery that we currently use cannot read documentation files and best
practices, it's rather a refactoring tool.
So I want to introduce CodeRabbit that allows creating .coderabbit.yaml with
custom rules and conventions.
Signed-off-by: Sergei Petrosian spetrosi@redhat.com
Summary by Sourcery
Add project-wide CodeRabbit configuration to enforce contribution conventions and tailored review guidance.
CI:
Chores: