perftest: add support for rocm dmabuf for additional operating systems#392
Open
gigabyte132 wants to merge 1 commit into
Open
perftest: add support for rocm dmabuf for additional operating systems#392gigabyte132 wants to merge 1 commit into
gigabyte132 wants to merge 1 commit into
Conversation
5a226d5 to
af0e6d0
Compare
Signed-off-by: Raulian-Ionut Chiorescu <raulian-ionut.chiorescu@cern.ch>
Author
|
Validated perftest with a test inside a containerized environment with W7900 Radeon Pro GPUs and 200G RoCEv2 capable NICs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some operating systems, especially the ones designed for running containers like
rhel bootcorfedoracoreosdon't expose"/boot/config-%s"but rather paths like/lib/modules/%s/config. This has already been fixed upstream in ROCM see: https://github.com/ROCm/rocm-systems/blob/develop/projects/rccl/src/misc/rocmwrap.cc#L282 .This PR adds DMABUF support in rdma-perftest for additional os's by looping over some common paths where the
/boot/config-%sequivalent livesadditionally it checks
/proc/kallsymsfor exported kernel symbols if none of the files match/are available, which is especially the case in containerized environments. This also follows the implemetation at ROCm upstream https://github.com/ROCm/rocm-systems/blob/develop/projects/rccl/src/misc/rocmwrap.cc#L367