floppy: fix reference leak on platform_device_register() failure#737
Open
blktests-ci[bot] wants to merge 1 commit intolinus-master_basefrom
Open
floppy: fix reference leak on platform_device_register() failure#737blktests-ci[bot] wants to merge 1 commit intolinus-master_basefrom
blktests-ci[bot] wants to merge 1 commit intolinus-master_basefrom
Conversation
Author
|
Upstream branch: 028ef9c |
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
8f17195 to
6b4d829
Compare
Author
|
Upstream branch: d60bc14 |
blktests-ci
bot
force-pushed
the
series/1080785=>linus-master
branch
from
86fdf86 to
adccf02
Compare
Author
|
Upstream branch: d60bc14 |
When platform_device_register() fails in do_floppy_init(), the embedded struct device in floppy_device[drive] has already been initialized by device_initialize(), but the failure path jumps to out_remove_drives without dropping the device reference for the current drive. Previously registered floppy devices are cleaned up in out_remove_drives, but the device for the drive that fails registration is not, leading to a reference leak. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fix this by calling put_device() for the current floppy device before jumping to the common cleanup path. Fixes: 94fd0db ("[PATCH] Floppy: Add cmos attribute to floppy driver") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
blktests-ci
bot
force-pushed
the
series/1080785=>linus-master
branch
from
adccf02 to
2749b75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: floppy: fix reference leak on platform_device_register() failure
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1080785