Skip to content

Commit b3ce769

Browse files
pccacmel
authored andcommitted
perf disasm: Fix off-by-one bug in outside check
If a branch target points to one past the end of a function, the branch should be treated as a branch to another function. This can happen e.g. with a tail call to a function that is laid out immediately after the caller. Fixes: 751b178 ("perf annotate: Mark jumps to outher functions with the call arrow") Reviewed-by: Ian Rogers <irogers@google.com> Signed-off-by: Peter Collingbourne <pcc@google.com> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Bill Wendling <morbo@google.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: James Clark <james.clark@linaro.org> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Justin Stitt <justinstitt@google.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Nathan Chancellor <nathan@kernel.org> Cc: Nick Desaulniers <nick.desaulniers+lkml@gmail.com> Cc: Peter Zijlstra <peterz@infradead.org> Link: https://linux-review.googlesource.com/id/Ide471112e82d68177e0faf08ca411d9fcf0a7bdf Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent 1e972ec commit b3ce769

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

tools/perf/util/disasm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,7 @@ static int jump__parse(const struct arch *arch, struct ins_operands *ops, struct
384384
start = map__unmap_ip(map, sym->start);
385385
end = map__unmap_ip(map, sym->end);
386386

387-
ops->target.outside = target.addr < start || target.addr > end;
387+
ops->target.outside = target.addr < start || target.addr >= end;
388388

389389
/*
390390
* FIXME: things like this in _cpp_lex_token (gcc's cc1 program):

0 commit comments

Comments
 (0)