Skip to content

Commit a0ac82c

Browse files
Haoxiang Liarndb
authored andcommitted
clk: spear: fix resource leak in clk_register_vco_pll()
Add a goto label in clk_register_vco_pll(), unregister vco_clk if tpll_clk is failed to be registered. Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Link: https://lore.kernel.org/r/20260325062204.169648-1-lihaoxiang@isrc.iscas.ac.cn Signed-off-by: Arnd Bergmann <arnd@arndb.de>
1 parent c7091fd commit a0ac82c

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/clk/spear/clk-vco-pll.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,13 +343,15 @@ struct clk *clk_register_vco_pll(const char *vco_name, const char *pll_name,
343343

344344
tpll_clk = clk_register(NULL, &pll->hw);
345345
if (IS_ERR_OR_NULL(tpll_clk))
346-
goto free_pll;
346+
goto unregister_clk;
347347

348348
if (pll_clk)
349349
*pll_clk = tpll_clk;
350350

351351
return vco_clk;
352352

353+
unregister_clk:
354+
clk_unregister(vco_clk);
353355
free_pll:
354356
kfree(pll);
355357
free_vco:

0 commit comments

Comments
 (0)