Skip to content

Commit 40805f3

Browse files
Manikanta Maddireddybjorn-helgaas
authored andcommitted
PCI: dwc: Apply ECRC workaround to DesignWare 5.00a as well
The ECRC (TLP digest) workaround was originally added for DesignWare version 4.90a. Tegra234 SoC has 5.00a DWC HW version, which has the same ATU TD override behaviour, so apply the workaround for 5.00a too. Fixes: a54e190 ("PCI: tegra194: Add Tegra234 PCIe support") Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com> Signed-off-by: Manivannan Sadhasivam <mani@kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Tested-by: Jon Hunter <jonathanh@nvidia.com> Reviewed-by: Jon Hunter <jonathanh@nvidia.com> Reviewed-by: Vidya Sagar <vidyas@nvidia.com> Link: https://patch.msgid.link/20260324190755.1094879-13-mmaddireddy@nvidia.com
1 parent ea60ca0 commit 40805f3

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

drivers/pci/controller/dwc/pcie-designware.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -487,13 +487,13 @@ static inline void dw_pcie_writel_atu_ob(struct dw_pcie *pci, u32 index, u32 reg
487487
static inline u32 dw_pcie_enable_ecrc(u32 val)
488488
{
489489
/*
490-
* DesignWare core version 4.90A has a design issue where the 'TD'
491-
* bit in the Control register-1 of the ATU outbound region acts
492-
* like an override for the ECRC setting, i.e., the presence of TLP
493-
* Digest (ECRC) in the outgoing TLPs is solely determined by this
494-
* bit. This is contrary to the PCIe spec which says that the
495-
* enablement of the ECRC is solely determined by the AER
496-
* registers.
490+
* DWC versions 0x3530302a and 0x3536322a have a design issue where
491+
* the 'TD' bit in the Control register-1 of the ATU outbound
492+
* region acts like an override for the ECRC setting, i.e., the
493+
* presence of TLP Digest (ECRC) in the outgoing TLPs is solely
494+
* determined by this bit. This is contrary to the PCIe spec which
495+
* says that the enablement of the ECRC is solely determined by the
496+
* AER registers.
497497
*
498498
* Because of this, even when the ECRC is enabled through AER
499499
* registers, the transactions going through ATU won't have TLP
@@ -563,7 +563,7 @@ int dw_pcie_prog_outbound_atu(struct dw_pcie *pci,
563563
if (upper_32_bits(limit_addr) > upper_32_bits(parent_bus_addr) &&
564564
dw_pcie_ver_is_ge(pci, 460A))
565565
val |= PCIE_ATU_INCREASE_REGION_SIZE;
566-
if (dw_pcie_ver_is(pci, 490A))
566+
if (dw_pcie_ver_is(pci, 490A) || dw_pcie_ver_is(pci, 500A))
567567
val = dw_pcie_enable_ecrc(val);
568568
dw_pcie_writel_atu_ob(pci, atu->index, PCIE_ATU_REGION_CTRL1, val);
569569

0 commit comments

Comments
 (0)