Skip to content

Commit ea60ca0

Browse files
Manikanta Maddireddybjorn-helgaas
authored andcommitted
PCI: tegra194: Use DWC IP core version
Tegra194 PCIe driver used custom version numbers to detect Tegra194 and Tegra234 IPs. With version detect logic added, version check results in mismatch warnings: tegra194-pcie 14100000.pcie: Versions don't match (0000562a != 3536322a) Use HW version numbers which match to PORT_LOGIC.PCIE_VERSION_OFF in Tegra194 driver to avoid these kernel warnings. Fixes: a54e190 ("PCI: tegra194: Add Tegra234 PCIe support") Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com> Signed-off-by: Manivannan Sadhasivam <mani@kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Tested-by: Jon Hunter <jonathanh@nvidia.com> Reviewed-by: Jon Hunter <jonathanh@nvidia.com> Reviewed-by: Vidya Sagar <vidyas@nvidia.com> Link: https://patch.msgid.link/20260324190755.1094879-12-mmaddireddy@nvidia.com
1 parent 8870f02 commit ea60ca0

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

drivers/pci/controller/dwc/pcie-designware.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,10 @@
3434
#define DW_PCIE_VER_470A 0x3437302a
3535
#define DW_PCIE_VER_480A 0x3438302a
3636
#define DW_PCIE_VER_490A 0x3439302a
37+
#define DW_PCIE_VER_500A 0x3530302a
3738
#define DW_PCIE_VER_520A 0x3532302a
3839
#define DW_PCIE_VER_540A 0x3534302a
40+
#define DW_PCIE_VER_562A 0x3536322a
3941

4042
#define __dw_pcie_ver_cmp(_pci, _ver, _op) \
4143
((_pci)->version _op DW_PCIE_VER_ ## _ver)

drivers/pci/controller/dwc/pcie-tegra194.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@
3535
#include <soc/tegra/bpmp-abi.h>
3636
#include "../../pci.h"
3737

38-
#define TEGRA194_DWC_IP_VER 0x490A
39-
#define TEGRA234_DWC_IP_VER 0x562A
38+
#define TEGRA194_DWC_IP_VER DW_PCIE_VER_500A
39+
#define TEGRA234_DWC_IP_VER DW_PCIE_VER_562A
4040

4141
#define APPL_PINMUX 0x0
4242
#define APPL_PINMUX_PEX_RST BIT(0)

0 commit comments

Comments
 (0)