-
Notifications
You must be signed in to change notification settings - Fork 85
Integration tests for support Linode integration with alerts #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: proj/aclp-linode-alerts
Are you sure you want to change the base?
Changes from 1 commit
2736865
e256458
2ca53cc
9d9834d
d06f462
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -234,6 +234,17 @@ def get_status(linode: Instance, status: str): | |||||||||||||||||||||||||||||
| def instance_type_condition(linode: Instance, type: str): | ||||||||||||||||||||||||||||||
| return type in str(linode.type) | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| def test_get_linodes_verify_alerts(test_linode_client): | ||||||||||||||||||||||||||||||
| linodes_list = test_linode_client.linode.instances().lists[0] | ||||||||||||||||||||||||||||||
| assert len(linodes_list) > 0 | ||||||||||||||||||||||||||||||
| assert linodes_list[0].alerts.cpu >= 0 | ||||||||||||||||||||||||||||||
| assert linodes_list[0].alerts.io >= 0 | ||||||||||||||||||||||||||||||
| assert linodes_list[0].alerts.network_in >= 0 | ||||||||||||||||||||||||||||||
| assert linodes_list[0].alerts.network_out >= 0 | ||||||||||||||||||||||||||||||
| assert linodes_list[0].alerts.transfer_quota >= 0 | ||||||||||||||||||||||||||||||
| assert isinstance(linodes_list[0].alerts.system_alerts, list) | ||||||||||||||||||||||||||||||
| assert isinstance(linodes_list[0].alerts.user_alerts, list) | ||||||||||||||||||||||||||||||
|
yec-akamai marked this conversation as resolved.
Outdated
|
||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
|
yec-akamai marked this conversation as resolved.
Outdated
Comment on lines
+255
to
+263
|
||||||||||||||||||||||||||||||
| linodes_list = test_linode_client.linode.instances().lists[0] | |
| assert len(linodes_list) > 0 | |
| assert linodes_list[0].alerts.cpu >= 0 | |
| assert linodes_list[0].alerts.io >= 0 | |
| assert linodes_list[0].alerts.network_in >= 0 | |
| assert linodes_list[0].alerts.network_out >= 0 | |
| assert linodes_list[0].alerts.transfer_quota >= 0 | |
| linode = test_linode_client.load(Instance, create_linode.id) | |
| assert linode.alerts.cpu >= 0 | |
| assert linode.alerts.io >= 0 | |
| assert linode.alerts.network_in >= 0 | |
| assert linode.alerts.network_out >= 0 | |
| assert linode.alerts.transfer_quota >= 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would implement extra filtering to find just created linode, but this test is like smoke test and in my opinion we don't need to check specific values. Do you see any benefit of this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test case to creat linode with aclp alerts? Adding system_alerts should be good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, please verify test just added: test_update_linode_aclp_alerts
Copilot
AI
Mar 31, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In test_linode_alerts_workflow, the test updates linode.alerts (cpu/io/network_*/transfer_quota) and calls linode.save(), but none of the subsequent assertions check that the update actually took effect. As written, the test would still pass even if the save was a no-op, which weakens the intended coverage. Consider asserting the saved values after a reload, and then align the clone assertions with the intended behavior (either the clone inherits the updated alerts, or it resets to defaults—right now it asserts the same default values as before the update).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not mistaken, values of
alerts.cpu, alerts.ipetc. cannot be lower than 0 (e.g. -10) so you can shorten these assertions and just use something like:assert linodes_list[0].alerts.cpu- it will pass when value > 0 and fail when value = 0There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that I was wrong here, i.e. when I run
test_get_linodes_verify_alertson DevCloud it fails becausenetwork_in=0so after the changes I suggested above the assertionassert linodes_list[0].alerts.network_inis not met. I missed that "0" is acceptable value