Only compile Fallback level on targets without a better baseline - #320
Open
Shnatsel wants to merge 4 commits into
Open
Only compile Fallback level on targets without a better baseline#320Shnatsel wants to merge 4 commits into
Shnatsel wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It emitted no LLVM IR, but it was still being type- and borrow-checked despite never being called.
When applied on top of #318 reduces x86 clean build time by 0.2s (from 2.15s to 1.95s) and Aarch64 build time by 0.3s (from 1.25s to 0.95s).
Fixes #316
There are two instances of this cfg, which is as low as I could get it. Could be brought down to one with a build script but that would negate the build time gains.