Move min/max and min_precise/max_precise to SimdBase - #313
Open
Shnatsel wants to merge 1 commit into
Open
Conversation
Shnatsel
changed the title
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows abstracting over integer and floating-point vectors.
I didn't include this into #308 because there's an API design choice here: do we expose
*_precisefor integers to allow abstracting over integers and floats, or keep them separate (and not merge this PR)?This PR makes the behavior consistent with #300 which exposes
*_saturatingfor both integers and floats to allow abstracting over them.