Skip to content

fix(console,cli): split the no-worker alert; remove moved CLI commands with tips; refresh CLI docs - #341

Merged
jfcmartins merged 9 commits into
mainfrom
fix/console-attention-split-no-worker
Nov 16, 2026
Merged

jfcmartins merged 9 commits into
mainfrom
fix/console-attention-split-no-worker

Conversation

@jfcmartins

@jfcmartins jfcmartins commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

What and why

The admin Overview showed "7 resources without a connected worker, so sessions will fail" on the dev compose stack. Nothing was broken. The 7 are the example pool: prod resources (orders-prod, warehouse-prod, catalog-atlas, logs-opensearch, orders-mq, payments-msk, reviews-docdb). They point at real AWS endpoints and the compose stack runs only pool=dev and pool=kube workers. The card added in #329 (ADR-0055) counted every resource without a tunnel, whether its workers dropped offline (an outage) or no enrolled worker matches its selector at all (a deployment fact), and raised the same red alarm for both.

This splits the line by cause:

  • workers enrolled but disconnected: red, "sessions will fail" (unchanged meaning)
  • no enrolled worker matches the selector: amber, no alarm wording

Both still link to the needs-attention filter, and the per-resource status (offline / no worker) is unchanged.

Related: ADR-0055, #329

How it was verified

  • cargo fmt --all, cargo clippy -p limen-control-plane --all-targets --all-features --locked -- -D warnings: clean.
  • Diagnosis against the running dev stack: Postgres components (workers pool=dev x3, pool=kube x1, live tunnels on one dev and the kube worker) versus policy_documents (exactly 7 resources with worker_selector: {pool: prod}).

Not verified

  • No test added: the Needs-you line is built from the live components/tunnels tables and the loaded policy, which only the integration tests (Postgres) cover, and none exercises this line. I did not run them and did not look at the rendered console after the change.

Checklist

  • Tests added or updated; cargo fmt and cargo clippy ... -D warnings clean (clippy clean, tests n/a, see above)
  • Docs updated (docs/guides/console.md)
  • Phase work: n/a
  • Secrets, mTLS, audit untouched
  • New dependency: n/a
  • New entry point or data store: n/a
  • Commits are conventional, small and focused

Compatibility and rollback

None. Display text only; revert the commit to roll back.

Also in this PR (CLI)

  • Breaking: the hidden top-level limen approve|deny|cancel|completions|manage are removed. Typing one prints unrecognized subcommand with tip: did you mean ... (limen requests approve, limen config completions, limen admin manage, ...). Also tips for the admin commands typed without admin (lock, token, apply ...) and for habit names (list, whoami, psql, kubectl ...). limen mcp moves to limen config mcp serve (what limen config mcp now prints for agents), and the old name gets the same tip.

  • Unit test: every tip parses to an existing command (--help), and the old names are unknown commands. cargo test -p limen-cli (127 + 2; the stdio test now spawns config mcp serve, and I ran a ping through it by hand) and clippy -D warnings pass. Checked the tips in a pseudo-terminal and piped. demos/demo-phase1.sh was edited but not run.

  • The held-for-approval hint now says limen admin manage changes approve.

  • docs/guides/cli.md (task table, admin list, moved commands, animation speeds, ls --watch/-q), management-api.md, ADR-0052 (amended) and ADR-0012 updated.

  • Docs and the console's policy hint no longer mention old command names (limen manage in policy.html and its page snapshot is now limen admin manage). The landing page already says limen config mcp; I found no limen mcp there. Not run: the console page tests (they need Postgres) and the website build.

@jfcmartins jfcmartins changed the title fix(console): separate offline workers from unserved resources in Needs you fix(console): split the no-worker alert; docs: stale 'limen manage' commands Nov 16, 2026
@jfcmartins jfcmartins changed the title fix(console): split the no-worker alert; docs: stale 'limen manage' commands fix(console,cli): split the no-worker alert; refuse moved commands in a terminal; refresh CLI docs Nov 16, 2026
@jfcmartins jfcmartins changed the title fix(console,cli): split the no-worker alert; refuse moved commands in a terminal; refresh CLI docs fix(console,cli): split the no-worker alert; remove moved CLI commands with tips; refresh CLI docs Nov 16, 2026
@jfcmartins
jfcmartins marked this pull request as ready for review November 16, 2026 14:48
@jfcmartins
jfcmartins merged commit 9003094 into main Nov 16, 2026
26 checks passed
@jfcmartins
jfcmartins deleted the fix/console-attention-split-no-worker branch November 16, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant