Repository navigation
fix(console,cli): split the no-worker alert; remove moved CLI commands with tips; refresh CLI docs - #341
Merged
Conversation
… the new command in a terminal
…anage; answer them with a tip
…cp' answers with a tip
…med before; console hint says 'limen admin manage'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The admin Overview showed "7 resources without a connected worker, so sessions will fail" on the dev compose stack. Nothing was broken. The 7 are the example
pool: prodresources (orders-prod, warehouse-prod, catalog-atlas, logs-opensearch, orders-mq, payments-msk, reviews-docdb). They point at real AWS endpoints and the compose stack runs onlypool=devandpool=kubeworkers. The card added in #329 (ADR-0055) counted every resource without a tunnel, whether its workers dropped offline (an outage) or no enrolled worker matches its selector at all (a deployment fact), and raised the same red alarm for both.This splits the line by cause:
Both still link to the needs-attention filter, and the per-resource status (
offline/no worker) is unchanged.Related: ADR-0055, #329
How it was verified
cargo fmt --all,cargo clippy -p limen-control-plane --all-targets --all-features --locked -- -D warnings: clean.components(workerspool=devx3,pool=kubex1, live tunnels on one dev and the kube worker) versuspolicy_documents(exactly 7 resources withworker_selector: {pool: prod}).Not verified
components/tunnelstables and the loaded policy, which only the integration tests (Postgres) cover, and none exercises this line. I did not run them and did not look at the rendered console after the change.Checklist
cargo fmtandcargo clippy ... -D warningsclean (clippy clean, tests n/a, see above)Compatibility and rollback
None. Display text only; revert the commit to roll back.
Also in this PR (CLI)
Breaking: the hidden top-level
limen approve|deny|cancel|completions|manageare removed. Typing one printsunrecognized subcommandwithtip: did you mean ...(limen requests approve,limen config completions,limen admin manage, ...). Also tips for the admin commands typed withoutadmin(lock,token,apply...) and for habit names (list,whoami,psql,kubectl...).limen mcpmoves tolimen config mcp serve(whatlimen config mcpnow prints for agents), and the old name gets the same tip.Unit test: every tip parses to an existing command (
--help), and the old names are unknown commands.cargo test -p limen-cli(127 + 2; the stdio test now spawnsconfig mcp serve, and I ran a ping through it by hand) and clippy-D warningspass. Checked the tips in a pseudo-terminal and piped.demos/demo-phase1.shwas edited but not run.The held-for-approval hint now says
limen admin manage changes approve.docs/guides/cli.md(task table, admin list, moved commands, animation speeds,ls --watch/-q),management-api.md, ADR-0052 (amended) and ADR-0012 updated.Docs and the console's policy hint no longer mention old command names (
limen manageinpolicy.htmland its page snapshot is nowlimen admin manage). The landing page already sayslimen config mcp; I found nolimen mcpthere. Not run: the console page tests (they need Postgres) and the website build.