Repository navigation
fix: kube stream grant end, web stream load slot, setup.sh on old bash, CI coverage gaps - #314
Merged
Merged
Conversation
The exec, attach and port-forward pump checked the session deadline and locks but not grant_ended, unlike must_stop for streaming responses. Both now share Admitted::stop_reason, which is unit-tested. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SEiXYYviUmZxCvQoG6xkeL
open_web_stream dropped its SessionSlot on return, so a long-lived WebSocket stopped counting toward the worker's load while it ran. The slot now moves into the relay task, as the kube path already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SEiXYYviUmZxCvQoG6xkeL
With --stacks none, bash before 4.4 (macOS /bin/bash) fails on an empty
"${stacks[@]}" under set -u. Use the guarded form the other calls use.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SEiXYYviUmZxCvQoG6xkeL
Six of the nine directories infra.yml validates had required_providers blocks Dependabot never checked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SEiXYYviUmZxCvQoG6xkeL
docs/cli-reference.md, docs/policy-schema, docs/guides/audit-ocsf.md, assets/logo-mark.svg and release.yml are read by tests, include_str! or check-versions.sh, but the path filter excluded them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SEiXYYviUmZxCvQoG6xkeL
jfcmartins
marked this pull request as ready for review
November 12, 2026 10:41
Collaborator
Author
|
Tests (Linux arm64) failed on Likely cause (from the log; I haven't reproduced it, since I had no PostgreSQL here):
So whether the replay is refused depends on how many bytes the logins left free, not on the replay itself. A possible fix, for the owner to choose:
I've left it unchanged here, because changing the audit fail-closed behaviour needs the owner's call. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Five small, independent fixes from a repository review. They don't overlap the open PRs (#304, #300, #276). One commit each:
exec/attach/port-forwardpump (kube/pump.rs) checked the session deadline and locks but notgrant_ended.must_stopdoes check it for streaming responses (kube/serve.rs).Admitted::stop_reason(kube/mod.rs), and the unusedexpiresargument is gone.open_web_streamdropped itsSessionSloton return, so a long-lived WebSocket stopped counting toward the worker's load. That under-countedp2cplacement,/tunnelsand the load reported to peers.kube.rsalready does.stacksarray insetup.sh.stack_policy_files "$root" "${stacks[@]}"fails underset -uon bash older than 4.4 (macOS/bin/bash3.2) when no stacks are chosen (--stacks none).${stacks[@]+"${stacks[@]}"}form every other call in the file uses.infra.ymlvalidates, and each has arequired_providersblock.rust.ymlruns for excluded files that the build or tests read.docs/,assets/,.github/) but are read anyway:docs/cli-reference.md,docs/policy-schema/**anddocs/guides/audit-ocsf.mdare compared by tests.assets/logo-mark.svgis pulled in byinclude_str!inlimen-cli..github/workflows/release.ymlis checked byscripts/check-versions.sh.Related: maintenance; no phase work.
How it was verified
cargo fmt --allandcargo clippy --workspace --all-targets --all-features --locked -- -D warningsare clean.protobuf-compiler3.21, not the 36.2 thatmise.tomlpins.cargo test -p limen-proxy -p limen-workerpasses (363 worker lib tests and the proxy suites).kube::testsforstop_reason: running, deadline, grant revoked or expired, and locked user.bash -n deploy/compose/setup.shpasses.-S warning) shows only the existing SC2154 forcompose.rust.ymlanddependabot.ymlparse as YAML.Not verified
setup.shon.actionlintandgitleaksweren't run (nomisehere). CI runs actionlint.Review guide
crates/limen-worker/src/kube/mod.rs(stop_reason). The checks run in the same order as the oldmust_stop: deadline, grant, then locks.Checklist
cargo fmtandcargo clippy ... -D warningscleanCompatibility and rollback
None. Revert any commit on its own.
Generated by Claude Code