Repository navigation
fix(ci): format proxy_revocation.rs and accept RUSTSEC-2026-0459 (libsqlite3-sys) - #293
Merged
Merged
Conversation
…sqlite3-sys) Main's rust workflow has failed since #292: proxy_revocation.rs was not rustfmt-clean, and a new advisory for libsqlite3-sys fails cargo audit. The crate is in Cargo.lock only, as sqlx's optional SQLite driver, and is never compiled. sqlx-sqlite 0.9.0 requires libsqlite3-sys below 0.38 and the fix is 0.39, so there is nothing to bump. Recorded in deny.toml, .cargo/audit.toml and ADR-0012.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Main's
rustworkflow has been red since #292 (0192809). Two causes, both unrelated to any feature work:crates/limen-e2e/tests/proxy_revocation.rswas notcargo fmt-clean, somise run checkstopped at the fmt step (and clippy never ran in CI after it).libsqlite3-sys0.37.0, fixed in 0.39.0), failscargo audit. The crate is inCargo.lockonly, assqlx's optional SQLite driver (sqlx-sqlite). It is never compiled:cargo tree -i libsqlite3-sysprints nothing for the workspace with all features. Limen usessqlxwith PostgreSQL only. A bump is not possible:sqlx-sqlite0.9.0 (the latest) requireslibsqlite3-sys >=0.30.1, <0.38.0. So the advisory is accepted with a reason indeny.toml,.cargo/audit.tomland the "Accepted advisories" table of ADR-0012, the same way RUSTSEC-2023-0071 is.Related: unblocks #290 (shadow mode), whose CI fails on these two checks only.
How it was verified
mise run check(the CI lint task): exit 0.cargo audit: exit 0.cargo deny --locked check: advisories, bans, licenses and sources ok.Not verified
ead6bcf; locally the workspace tests pass (apart from ninereplicastests that need a newer dev database).Checklist
cargo fmtandcargo clippy ... -D warningsclean (n/a: no code change beyond formatting)Compatibility and rollback
None. Revert the commit to restore the previous (failing) state. Drop the advisory ignore when
sqlxships asqlx-sqlitethat allowslibsqlite3-sys0.39 or later.