Skip to content

fix(ci): format proxy_revocation.rs and accept RUSTSEC-2026-0459 (libsqlite3-sys) - #293

Merged
jfcmartins merged 1 commit into
mainfrom
fix/main-ci
Nov 9, 2026
Merged

jfcmartins merged 1 commit into
mainfrom
fix/main-ci

Conversation

@jfcmartins

Copy link
Copy Markdown
Collaborator

What and why

Main's rust workflow has been red since #292 (0192809). Two causes, both unrelated to any feature work:

  1. crates/limen-e2e/tests/proxy_revocation.rs was not cargo fmt-clean, so mise run check stopped at the fmt step (and clippy never ran in CI after it).
  2. A new advisory, RUSTSEC-2026-0459 (libsqlite3-sys 0.37.0, fixed in 0.39.0), fails cargo audit. The crate is in Cargo.lock only, as sqlx's optional SQLite driver (sqlx-sqlite). It is never compiled: cargo tree -i libsqlite3-sys prints nothing for the workspace with all features. Limen uses sqlx with PostgreSQL only. A bump is not possible: sqlx-sqlite 0.9.0 (the latest) requires libsqlite3-sys >=0.30.1, <0.38.0. So the advisory is accepted with a reason in deny.toml, .cargo/audit.toml and the "Accepted advisories" table of ADR-0012, the same way RUSTSEC-2023-0071 is.

Related: unblocks #290 (shadow mode), whose CI fails on these two checks only.

How it was verified

  • mise run check (the CI lint task): exit 0.
  • cargo audit: exit 0. cargo deny --locked check: advisories, bans, licenses and sources ok.

Not verified

  • That the CI run on this PR is green: it starts when the PR is marked ready. The Linux/macOS test jobs were skipped in CI on main's red lint, so they have not run on ead6bcf; locally the workspace tests pass (apart from nine replicas tests that need a newer dev database).

Checklist

  • Tests added or updated; cargo fmt and cargo clippy ... -D warnings clean (n/a: no code change beyond formatting)
  • Docs updated (ADR-0012 accepted advisories)
  • Phase work: n/a
  • Secrets stay out of logs; mTLS and fail-closed audit intact (n/a)
  • New dependency: n/a. Accepted advisory recorded in ADR-0012
  • New entry point or data store: n/a
  • Commits are conventional, small and focused

Compatibility and rollback

None. Revert the commit to restore the previous (failing) state. Drop the advisory ignore when sqlx ships a sqlx-sqlite that allows libsqlite3-sys 0.39 or later.

…sqlite3-sys)

Main's rust workflow has failed since #292: proxy_revocation.rs was not
rustfmt-clean, and a new advisory for libsqlite3-sys fails cargo audit.
The crate is in Cargo.lock only, as sqlx's optional SQLite driver, and is
never compiled. sqlx-sqlite 0.9.0 requires libsqlite3-sys below 0.38 and
the fix is 0.39, so there is nothing to bump. Recorded in deny.toml,
.cargo/audit.toml and ADR-0012.
@jfcmartins
jfcmartins marked this pull request as ready for review November 9, 2026 10:55
@jfcmartins
jfcmartins merged commit b1858ca into main Nov 9, 2026
21 checks passed
@jfcmartins
jfcmartins deleted the fix/main-ci branch November 9, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant