Skip to content

chore(assets): remove four unreferenced README icons - #280

Merged
jfcmartins merged 1 commit into
mainfrom
claude/laughing-bohr-8jyku4
Nov 8, 2026
Merged

jfcmartins merged 1 commit into
mainfrom
claude/laughing-bohr-8jyku4

Conversation

@jfcmartins

@jfcmartins jfcmartins commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

What and why

Removes assets/icons/{hard-drive,key-round,plug,shield-check}.svg. Nothing in the README, website, docs or crates references them; the README uses only terminal, globe, network, bot and scroll-text. The console and site carry their own icon copies. LICENSE-lucide.txt stays because the remaining icons are Lucide.

Found in a scheduled repo review (dead files, risky patterns, missing tests). This is the only change; I did not find other issues I could support with evidence.

Related: none. Open PRs #276 and #277 are release work and do not overlap.

How it was verified

  • git grep for each file name and for assets/icons across the repo: only the five remaining icons are referenced (README.md).
  • No Rust, config or generated files changed, so cargo checks were not run.

Not verified

  • Website build and rendered README (not run).

Review findings, not fixed

  • Reviewed: production unwrap/expect sites (all documented invariants), shell scripts (bash -n ok, set -euo pipefail), workflow actions (pinned by SHA, no pull_request_target), name-pattern matching, tunnel framing. No confirmed bugs.
  • Needs verification: identity_assertion_matches in crates/limen-proxy/src/web.rs checks claims and signature length but not the signature itself. This looks intentional (the assertion comes from the control plane over mTLS), but worth confirming.
  • Needs verification: limen_kube::spdy::build::data/control truncate payload length to 24 bits with as u32. They appear test-only, so no impact found.
  • Needs verification: docs/diagrams/mermaid/mermaid-71f20e90ccff.*.svg may be stale if its source block was removed.

Checklist

  • Tests added or updated; cargo fmt and cargo clippy ... -D warnings clean: n/a (asset removal only)
  • Docs updated: n/a
  • Phase work: n/a
  • Secrets/mTLS/audit intact: n/a
  • New dependency: n/a
  • New entry point or data store: n/a
  • Commits are conventional, small and focused

Compatibility and rollback

None. Revert the commit to restore the files.

@jfcmartins
jfcmartins marked this pull request as ready for review November 7, 2026 23:44
hard-drive, key-round, plug and shield-check under assets/icons are not used by
the README, the website or the docs (the console and site carry their own
copies). LICENSE-lucide.txt stays: the remaining icons are Lucide.
@jfcmartins
jfcmartins force-pushed the claude/laughing-bohr-8jyku4 branch from 889f1fc to 66d685c Compare November 8, 2026 00:12
@jfcmartins
jfcmartins merged commit 3a6837a into main Nov 8, 2026
1 check passed
@jfcmartins
jfcmartins deleted the claude/laughing-bohr-8jyku4 branch November 8, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant