Repository navigation
chore(assets): remove four unreferenced README icons - #280
Merged
Merged
Conversation
jfcmartins
marked this pull request as ready for review
November 7, 2026 23:44
hard-drive, key-round, plug and shield-check under assets/icons are not used by the README, the website or the docs (the console and site carry their own copies). LICENSE-lucide.txt stays: the remaining icons are Lucide.
jfcmartins
force-pushed
the
claude/laughing-bohr-8jyku4
branch
from
November 8, 2026 00:12
889f1fc to
66d685c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Removes
assets/icons/{hard-drive,key-round,plug,shield-check}.svg. Nothing in the README, website, docs or crates references them; the README uses only terminal, globe, network, bot and scroll-text. The console and site carry their own icon copies.LICENSE-lucide.txtstays because the remaining icons are Lucide.Found in a scheduled repo review (dead files, risky patterns, missing tests). This is the only change; I did not find other issues I could support with evidence.
Related: none. Open PRs #276 and #277 are release work and do not overlap.
How it was verified
git grepfor each file name and forassets/iconsacross the repo: only the five remaining icons are referenced (README.md).Not verified
Review findings, not fixed
unwrap/expectsites (all documented invariants), shell scripts (bash -nok,set -euo pipefail), workflow actions (pinned by SHA, nopull_request_target), name-pattern matching, tunnel framing. No confirmed bugs.identity_assertion_matchesincrates/limen-proxy/src/web.rschecks claims and signature length but not the signature itself. This looks intentional (the assertion comes from the control plane over mTLS), but worth confirming.limen_kube::spdy::build::data/controltruncate payload length to 24 bits withas u32. They appear test-only, so no impact found.docs/diagrams/mermaid/mermaid-71f20e90ccff.*.svgmay be stale if its source block was removed.Checklist
cargo fmtandcargo clippy ... -D warningsclean: n/a (asset removal only)Compatibility and rollback
None. Revert the commit to restore the files.