Repository navigation
ci(release): bump the rc number automatically instead of pinning release-as - #279
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The release PR kept proposing
0.1.0-rc.2after rc.2 shipped, becauserelease-aswas still set inrelease-please-config.json. That setting forces the version.This drops
release-asand setsversioning: prereleasewithprerelease-type: rc, so the next release PR bumps the rc number by itself (rc.3, rc.4, ...). The runbook and ADR-0024 now sayrelease-asis a one-release override to remove right after it ships, and how to go from rc to a final version.Related: ADR-0024. The stale release PR #276 should be rewritten by release-please after merge.
How it was verified
release-please-config.jsonparses as JSON.unverified: not run against release-please. The rc.N bump comes from its documented prerelease strategy, not from observation.Not verified
What release-please proposes on
mainafter merge (expect0.1.0-rc.3, not0.2.0). If it is wrong, setrelease-asfor that one release.Checklist
Compatibility and rollback
Release tooling config only. Revert to roll back; set
release-asto force a version.