Fix fail-open async UMA validation checks#524
Conversation
|
Thank you for the review! I took a second look at the failing CI jobs and they don't seem to be related to this change. The failures seem to be related to the existing test environment/integration setup, not the async validation fix itself. The main changes here are just waiting on Promise validation checks to avoid fail-open behavior in UMA guard paths. I can also rebase or make any requested adjustments if needed to help push this forward. |
Looks like we need to update some secrets in this repo. Your changes are safe :-). |
Summary
awaitto async compliance check inSendingVasp.handleClientUmaLookupawaitto async balance checks inSendingVasp.handleClientUmaPayreqandSendingVasp.handleClientSendPaymentawaitto async compliance check inReceivingVasp.handleUmaLnurlpWhy
These guards call methods returning
Promise<boolean>. Withoutawait, the Promise object is always truthy and can cause fail-open behavior.Validation
npx -y yarn workspace @lightsparkdev/uma-vasp build