Skip to content

Fix fail-open async UMA validation checks#524

Merged
jklein24 merged 1 commit into
lightsparkdev:developfrom
SOME-1HING:fix/uma-await-validation-checks
May 25, 2026
Merged

Fix fail-open async UMA validation checks#524
jklein24 merged 1 commit into
lightsparkdev:developfrom
SOME-1HING:fix/uma-await-validation-checks

Conversation

@SOME-1HING
Copy link
Copy Markdown

Summary

  • add missing await to async compliance check in SendingVasp.handleClientUmaLookup
  • add missing await to async balance checks in SendingVasp.handleClientUmaPayreq and SendingVasp.handleClientSendPayment
  • add missing await to async compliance check in ReceivingVasp.handleUmaLnurlp

Why

These guards call methods returning Promise<boolean>. Without await, the Promise object is always truthy and can cause fail-open behavior.

Validation

  • npx -y yarn workspace @lightsparkdev/uma-vasp build

@SOME-1HING SOME-1HING requested a review from a team as a code owner May 25, 2026 03:45
Copy link
Copy Markdown
Contributor

@jklein24 jklein24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SOME-1HING
Copy link
Copy Markdown
Author

Thank you for the review!

I took a second look at the failing CI jobs and they don't seem to be related to this change. The failures seem to be related to the existing test environment/integration setup, not the async validation fix itself.

The main changes here are just waiting on Promise validation checks to avoid fail-open behavior in UMA guard paths.

I can also rebase or make any requested adjustments if needed to help push this forward.

@jklein24 jklein24 changed the base branch from main to develop May 25, 2026 20:15
@jklein24
Copy link
Copy Markdown
Contributor

Thank you for the review!

I took a second look at the failing CI jobs and they don't seem to be related to this change. The failures seem to be related to the existing test environment/integration setup, not the async validation fix itself.

The main changes here are just waiting on Promise validation checks to avoid fail-open behavior in UMA guard paths.

I can also rebase or make any requested adjustments if needed to help push this forward.

Looks like we need to update some secrets in this repo. Your changes are safe :-).

@jklein24 jklein24 merged commit 1128b0f into lightsparkdev:develop May 25, 2026
5 of 7 checks passed
@SOME-1HING SOME-1HING deleted the fix/uma-await-validation-checks branch May 26, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants