Remove the ldk-node integration build from CI until we have a better process#4564
Remove the ldk-node integration build from CI until we have a better process#4564joostjager wants to merge 1 commit intolightningdevkit:mainfrom
ldk-node integration build from CI until we have a better process#4564Conversation
|
👋 Hi! I see this is a draft PR. |
tnull
left a comment
There was a problem hiding this comment.
It's not that we don't have a process for fixing it and usually (at least recently) people are opening the fixes relatively quick. However, they simply need time to land on their own right, which is why the CI is often failing.
We introduced the CI job for good reason, exactly to communicate API breakage. So just dropping it again doesn't make the problem go away, it will just reduce awareness (and hence motivation for people to act on it).
I agree we might need a better process for fixing it, but just dropping the CI job and going back to the previous status quo is not an improvement, IMO.
|
I think the problem is simply that the time to land a fix in |
Well, but it would send the signal where the contributors that need to receive it are likely not listening. |
|
I think the current setup has the same problem: the check in More broadly, I do not think we should keep low-signal jobs in main CI, regardless of whether the cause is technical or process-related. |
|
Then we should probably move to automatically opening an issue and tagging the original PR author when ldk node breaks after a merge, no? That seems like a process that is maybe more likely to work. |
|
That may help with awareness, but I do not think it fully solves the underlying problem either, because the breakage can stack up while fixes are pending, so it is still not a particularly clean or timely signal. In any case, I think this false flag should be moved out of the |
Yup, just from my experience I can report that I usually ignore #4511, as 99% I'm mentioned there it's pre-existing breakage. |
|
I definitely mentally track it - if there's existing breakage I look at it once every few days to make sure its still just the fuzz job . Note that 4511 does't fire for ldk node breakage. |
|
I think that is different, though, because those notifications are about breakage within the same repo and for checks that are not expected to fail very often, they mostly just exercise a broader platform matrix. |
|
I think the key question is whether we have a concrete path to making this a high-signal CI job again. From my perspective, the process so far has not achieved that, and the diagram makes that pretty clear. If the view is that |
The
LDK Node Integration Testsworkflow is not currently providing a useful CI signal onmain.Since January 1, 2026, its decisive-run pass rate was 29.05% (
43/148), with the first completed run in that window on January 5, 2026. At that level, a failure is not very informative, and it distracts from otherwise green builds.Proposed change
Remove the
ldk-nodeintegration workflow from this repository until there is a process that makes it a trustworthy signal again.This check likely belongs in
ldk-nodeCI instead, since that is also where the fix often needs to be made.This can always be reverted later if needed.
Before reintroducing it
rust-lightningandldk-nodechanges.