fix: resolve long-deferred FIXMEs for Lift 5.0#2053
Merged
farmdawgnation merged 2 commits intolift-5.0from Apr 7, 2026
Merged
Conversation
- Remove runFunction from LiftServlet finally block (explicitly held for next major version) - Rename CSSHelpers → CssHelpers for consistent capitalization (breaking change, appropriate for 5.0) - Remove stale HTML5 browser-detection FIXME comments from SHtml Scaladocs - Remove scala.language.existentials SI-6541 workaround (fixed since Scala 2.12) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
upstream dropped Scala 2.13 (fa56024), so the scala-2.13 test file is deleted in favour of the consolidated scala/ version. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mailing List thread:
REPLACE THIS WITH ML LINK
Resolves four FIXMEs that were explicitly deferred to a future major version, now that Lift 5.0 is the target:
runFunctionfrom thefinallyblock inhandleGenericContinuation— it was only kept there for 3.x backwards compatibility and now correctly runs only after a successfulsuspend().Autofocus,Required, andPlaceholder— browser detection for HTML5 fallback is permanently obsolete.scala.language.existentialsimport workaround for SI-6541, a Scala 2.10/2.11 compiler bug that was fixed in 2.12; the project now targets Scala 2.13 and 3.3.