chore: fix stVaults docs - #997
Merged
Merged
Conversation
tamtamchik
requested
a balanced review from Copilot
and removed request for
a team
September 16, 2026 12:01
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Several passages misidentify the Mellow vault, overstate deposit-pausing conditions, or conflict on distribution semantics.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Corrects stVault documentation, CLI examples, terminology, permissions, and protocol behavior.
Changes:
- Updates operational commands and parameter constraints.
- Clarifies stVault accounting, roles, withdrawal, and disconnection behavior.
- Fixes terminology, links, and redirects.
File summaries
| File | Description |
|---|---|
vault-owners-curators-and-stakers/index.md |
Fixes operation descriptions. |
non-custodial-operations.md |
Clarifies roles and timelock operations. |
defi-wrapper/.../health-guide.md |
Clarifies shortfall units. |
defi-wrapper/.../disconnection.md |
Revises the disconnection workflow. |
defi-wrapper/stakers/supply-withdraw.md |
Corrects stv withdrawal instructions. |
basic-stvaults/validate-setup.md |
Updates the vault-info command. |
basic-stvaults/rebalance.md |
Corrects shortfall behavior. |
basic-stvaults/health-monitoring-guide.md |
Corrects reserve-ratio capacity. |
basic-stvaults/health-emergency-guide.md |
Corrects reserve-ratio capacity. |
basic-stvaults/disconnection.md |
Updates oracle-report submission. |
basic-stvaults/control-validators.md |
Generalizes partial-withdrawal errors. |
update-strategy-implementation.md |
Formats generated salts correctly. |
pdg-shortcut-bootstrap-guide.md |
Uses the role’s bytes32 hash. |
manage-withdrawal-queue.md |
Clarifies withdrawal-fee handling. |
consolidation.md |
Updates CLI argument names. |
stvaults-technical-design.md |
Revises protocol mechanics and terminology. |
roles-and-permissions.md |
Clarifies ownership and role requirements. |
metrics.md |
Corrects Carry Spread interpretation. |
exit-validators-permissions.md |
Clarifies partial-withdrawal conditions. |
defi-wrapper-technical-design.md |
Updates Wrapper architecture details. |
multi-user-staking-with-earn-eth.md |
Corrects Earn ETH deployment guidance. |
multi-user-staking-with-custom-strategy.md |
Updates deployment and migration guidance. |
multi-user-delegated-staking.md |
Fixes repository links and tier timing. |
staking_with_redemptions_through_steth.md |
Updates confirmation-lifetime limits. |
leveraged-staking-product.md |
Updates confirmation-lifetime limits. |
basic-isolated-staking-setup.md |
Updates confirmation-lifetime limits. |
docusaurus.config.js |
Corrects a legacy redirect target. |
Review details
- Files reviewed: 27/27 changed files
- Comments generated: 5
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.