docs: refresh verification skills and add allowlist workflow - #216
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Readiness assessments conflict, and the validation guidance has an unresolved behavioral inaccuracy.
Pull request overview
Refreshes verification workflows and adds guidance for tightly scoped allowed differences.
Changes:
- Updates config, debugging, deployment, and explorer workflows.
- Adds allowlist guidance and diagnostic references.
- Refreshes workflow and tooling documentation.
File summaries
| File | Description |
|---|---|
CLAUDE.md |
Updates workflow and architecture references. |
.claude/skills/validate-config/SKILL.md |
Modernizes validation guidance. Nit: clarify that any: true can allow caught simulation errors. |
.claude/skills/new-config/SKILL.md |
Revises deployment-config creation guidance. |
.claude/skills/debug-diff/SKILL.md |
Aligns debugging with JSON reports. |
.claude/skills/debug-diff/references/diagnostic-recipes.md |
Adds focused diagnostic recipes. |
.claude/skills/allowed-diffs/SKILL.md |
Adds narrowly scoped exception guidance. |
.claude/skills/allowed-diffs/references/check-immutable-rule.md |
Adds an immutable-rule coverage check. |
.claude/skills/add-explorer/SKILL.md |
Updates explorer integration guidance. |
.claude/skills/add-explorer/references/response-mapping.md |
Documents payload normalization. |
Review details
Suppressed comments (1)
.claude/skills/validate-config/SKILL.md:35
- This overstates the failure behavior:
process_configmarks a caughtDeploymentSimulationErrorasallowedwhen the contract has a bytecodeany: truerule. Calling all caught bytecode errors failed can make config reviews miss that this wildcard suppresses simulation failures; document the exception explicitly.
`load_config` validates `allowed_diffs` through `diffyscan/utils/allowed_diffs.py`. Schema validity does not justify a rule: inspect reason and scope. Use [allowed-diffs](../allowed-diffs/SKILL.md) when tightening or adding exceptions. `fail_on_bytecode_comparison_error: false` can let an outer contract error continue, but caught bytecode errors still produce failed results.
- Files reviewed: 9/9 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
TheDZhon
approved these changes
Sep 7, 2026
TheDZhon
left a comment
Contributor
There was a problem hiding this comment.
No actionable findings in PR #216 (#216), reviewed at 2d01b85. Rechecked GitHub; the head is unchanged.
The revised workflows match the runtime behavior, including allowlist restrictions, constructor overrides, and simulation-error handling.
Validation:
- 410 tests passed
- Five skill metadata records and 32 local links/anchors validated
- Embedded immutable-rule example passed all six assertions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repository skills contained stale config requirements, references to removed verifier functions, and guidance that could hide unverified bytecode. Update the four existing workflows against the current implementation and add a dedicated
allowed-diffsworkflow for justified exceptions and wildcard tightening.Keep detailed explorer payload mappings and diagnostic recipes in linked references, including an executable immutable-rule coverage check. Preserve manual invocation settings and argument hints, and update the workflow index in
CLAUDE.md.Clarify the limits of source hunk rules, the prerequisites for constructor overrides inside allowlist rules, and the deployment-simulation exception accepted by bytecode wildcards. Keep config review separate from edits and live diagnostics, and correct the architecture description of immutable analysis. Explain recursive filename lookup, missing-source suggestions, token fallback and the simulation gas setting.
Validation