fix(cursor): show Fable policy review instructions and approval link - #4509
fix(cursor): show Fable policy review instructions and approval link#4509HeiTuz wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. |
리뷰 · 우선순위 70 / 80이 PR은 Cursor가 Claude Fable 5 data-retention 정책 동의를 요구할 때 Codex에 PR은 보안 태도가 좋습니다. upstream 텍스트를 그대로 보여 주면 키워드 분류나 비밀 누출 위험이 있는데, 코드 소유 문구 + 공식 URL만 쓰는 선택은 이 저장소 스타일에 맞습니다. 테스트가 binary-only, debug 무시, malformed/oversized, 필드 한도, 다른 Connect code까지 넓습니다. 다만 PR이 아직 draft이고, 로컬 full suite에 이 경로와 무관한 baseline 실패가 있어 ready를 미뤘다고 본문에 적혀 있습니다. types/config 분할과 무관합니다. structure 문서에 같은 문장이 여러 파일로 반복 추가된 점은 조금 시끄럽지만, structure:check를 통과했다면 형식상 문제는 아닙니다. 경로/심볼 - 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
|
Superseded by c66709f, which carries this work onto Your change is in that commit with a Why it was carried rather than merged directly: this branch had gone into conflict against Issue #4508 is closed against that merge. Thank you for the fix. |
Summary
When Cursor blocks Fable pending its data-retention policy acknowledgement, Codex currently shows only
failed_precondition: Error. Recognize the capturedaiserver.v1.ErrorDetailsbinary policy gate and show the explanation plus the official review URL: https://cursor.com/dashboard/restricted_models/claude-fable-5. Users sign in with the same Cursor account, review the policy themselves, and then retry.The decoder is deliberately limited to the observed MODEL_BLOCKED enum and exact Fable policy title/detail. It reads the protobuf
value, never the optionaldebugrepresentation. Encoded size, field count, entry count and string lengths are bounded. Output is code-owned text and one fixed official URL; upstream buttons, arbitrary links, analytics and consent commands are ignored. Other or malformed details retain existing behaviour. The rejection remains non-retryable HTTP 400 /invalid_request_error; the patch neither accepts the policy nor changes account settings.Fixes #4508. This addresses the verified Fable gate; general structured-error presentation remains outside this patch. If Cursor changes that signature, the safe generic fallback applies.
Verification
bun run typecheck,bun run privacy:scan,bun run structure:check: passed.cd docs-site && bun run build: passed, 441 pages.debugfield removed. The patched parser and adapter error formatter produced the policy explanation and official review URL, retaining status 400.CURSOR_PROBE_OK. This confirms current model access, not deployment of this PR or proof of what changed the account's policy state. No policy consent was accepted by the diagnostic code.Full-suite limitation (draft)
bun run testwas run. The parallel lane had 24,558 passes and two failures inremote-workspace-command-runner.test.ts: the npm-installed Bun executable has two hardlinks while that fixture requires a private executable. Retesting that file using a separate single-link copy of the same Bun binary passed 13/13.The serial lanes had one additional failure:
Codex autostart shim > Unix install rejects delayed detached redispatch after the launcher closes its lease fd. The exact test also fails in a separate unmodified dev worktree at 94063d0 with the same assertion (expected false, received true). It is outside the changed Cursor path. No unrelated runtime or test change is included to hide that baseline failure. The PR stays draft rather than claiming the complete local suite is green.Checklist
Review readiness checklist
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.