feat(dashboard): add dictation and live voice API controls - #4395
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
✅ READY
Hygiene✅ Deterministic PR hygiene checks passed. |
리뷰 · 우선순위 50 / 80이 PR은 오디오 스택 wp3(대시보드)입니다. 부모는 #4392(
UI 역할 분리는 분명합니다. DictationPanel은 파일 업로드+취소+트랜스크립트 표시와 스트리밍 예제(복붙)를 보여주고, LiveVoicePanel은 WebSocket 연결 상태·이벤트 타입 몇 줄을 보여 줍니다. “configured”는 계정 health/ entitlement가 아니라 프로바이더 설정 존재만 뜻한다고
메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
No conflicts. The connections dashboard branch already contained the streaming ancestor; this merge only fast-forwards that ancestor to the refreshed origin/dev + transcription + streaming stack.
Adds the standalone transcription API surface with its sidecar routing, auth-cors wiring and focused coverage. Bottom link of the audio stack; CI evidence is the stack tip #4395 run 34731037202.
|
Maintainer integration record — audio stack tip, merged by @lidge-jun. This is the tip of the cumulative audio stack, so merging it lands the whole lane in one commit: #4391 (transcription API), #4392 (streaming dictation and owned live calls), and #4395 (dashboard controls). #4391 was squashed separately beforehand; #4392's content arrives here.
Squashing with |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec9e3734e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| transcriptionEndpoint: `${baseUrl}/audio/transcriptions`, | ||
| dictationStreamEndpoint: `${socketBase.href}/audio/transcriptions/stream`, | ||
| liveEndpoint: `${socketBase.href}/live`, | ||
| realtimeCallsEndpoint: `${baseUrl}/realtime/calls`, |
There was a problem hiding this comment.
Route connected audio controls to the hub data plane
When a connected-client dashboard uses direct management transport to a wildcard-bound hub, the cross-origin /api/keys request carries the machine dashboard's Origin, which resolveApiAccessBaseUrl prefers over the hub request URL. These new endpoints therefore point to the local machine listener, but src/client/machine-listener.ts rejects every /v1 request and all WebSocket upgrades, so transcription returns 404 and Live Voice cannot connect. Derive executable audio endpoints from the connected hub's inference origin, or provide a data-plane relay instead of reusing this request-origin display base.
Useful? React with 👍 / 👎.
Summary
codex/audio-streaming; final integration target remainsdev. No native GitHub stack or merge requested.Verification
--no-verify.066091134b5d30297fb9b9c4460378a689ecb41f: remote gates 103544812802 passed lint, typecheck, 1,998 dashboard tests / 0 failures, privacy and build. Screenshot/description gate also passed. Runtime/UI source is unchanged fromf5aefd88af3116bec4f2ddc72c0c6fa974f52a83, whose remote metadata tests passed 10/10.bb0f30fbab4496b2b69bbc1e8148e59035ba3778GUI tree exactly equals the runtime/UI source tree.xai/grok-4.6as requested.011f2dff5ca3667b88f090fe711c4b2c77efd190passed all new audio cases and gates in run 34687731903. Existing journal restore failures remain separately recorded per owner scope; no whole-suite-green claim.Checklist