feat(remote): carry bounded executor and hub runtime foundations - #4362
Conversation
Carry #3458 runtime foundations with explicit session grants, private state stores and fail-closed Windows command support. Keep server and dashboard activation for the dependent integration layer. Co-authored-by: Ingwannu <ingwannu@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
리뷰 · 우선순위 42 / 80이 PR은 Remote Workspace의 executor·Hub 런타임 기초를 가져옵니다. 승인된 workspace root, 암호화 RPC, 세션 capability grant, 재연결, private state 발행이 포함됩니다. 모델 런타임 어댑터는 Hub에 두고, 이 레이어는 서버 활성화를 추가하지 않는다고 본문에 명시되어 있습니다. 원본 계보는 #3458이고, base는 머지 순서가 중요합니다. 안내된 체인: #4344 inactive workspace protocol → 이 PR(#4362) executor/hub foundations → #4372 dashboard/admission. 현재 규모가 큽니다(+9983/−47, 62 files). TypeScript 쪽은 라인 / 심볼 - merge-order - #4344 미랜딩 상태에서 이 PR을 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
…time foundation [skip ci] Resolve nine structure/ append conflicts by keeping both sides: dev's new quota/history/Cline/effort notes and this branch's Remote Workspace publisher line. Every conflict had an empty merge base, so neither side replaced the other.
⏳ DRAFT
What to do
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved. |
…ng flow [skip ci] Both device-reauth GUI tests failed on this branch before the merge. The first clicked button.codex-auth-action-btn, but the always-rendered pause control ships the same class and renders first, so the click hit pause and starts stayed 0; select by label the way the cancel test already does. The second awaited start() to completion while the mock always answers pending, and start() owns the flow until a terminal status, so it timed out at 5s; drive it and wait for the first poll to land instead. Product code is unchanged.
… ci] oxlint's react-compiler pass lowers a for statement and asserts its init is a variable declaration, so the empty init in for (;;) raised "Invariant: Expected a variable declaration" and blamed the enclosing hook. GUI lint runs in hosted CI, so this failed the gate. The loop body already returns on abort, unmount or a replaced flow id, and nothing follows the loop, so keying the loop on the same abort signal preserves behavior exactly.
…undation [skip ci]
…time foundation [skip ci]
1 participant
Summary
codex/260912-60plus-remote; review the layer delta. Original feat(remote-control): add hub-mediated remote workspaces #3458 remains open.Verification
bun scripts/structure-ssot.ts --fixdocumentation consistency passed;git diff --checkand relative-import path inspection passed.Checklist
Current manual chain: #4344 (
726ddc7fc0704c45299eef785e70624a07303784) -> #4362 (a3182185f0e089504d72e5729e4674cf0dc07ea1) -> #4372 (5c462fec1a1454a41e926a429acbdf1adf1e3bdf). Final hosted run 34675511791 is pending; no passing result is claimed. Maintainer security/architecture review is still required.