-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(codex): select account models alongside pooled native entries #4183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
thisisjun786
wants to merge
14
commits into
lidge-jun:dev
from
thisisjun786:codex/account-model-picker
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9b2a599
feat(codex): select account models alongside pooled native entries
thisisjun786 65d1522
Merge remote-tracking branch 'upstream/dev' into codex/account-model-…
thisisjun786 30f9818
fix(gui): declare shared mutation guard dependencies
thisisjun786 f2037b1
fix(codex): reject unavailable account picker models
thisisjun786 7b2f3dc
Merge remote-tracking branch 'upstream/dev' into codex/account-model-…
thisisjun786 28f01c0
fix(codex): accept o-series account model selections
thisisjun786 3cf258e
fix(codex): preserve routing and account selection lifecycle
thisisjun786 7625872
docs(api): clarify retained account selector handling
thisisjun786 c17c0ac
fix(codex): preserve live pooled models and expose eligible Reserve
thisisjun786 74f535e
fix(codex): converge Reserve and prune stale picker selections
thisisjun786 48485ca
fix(codex): include selected Reserve in live model discovery
thisisjun786 59c4f5a
fix(codex): honor disabled Reserve models in live discovery
thisisjun786 10b39ef
test(codex): assert disabled Reserve rows remain hidden
thisisjun786 6b6a3c6
fix(codex): prune selections for removed account namespaces
thisisjun786 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # Selective Codex account models | ||
|
|
||
| Understood as: register selected account/model pairs in OpenCodex for review harnesses while preserving common pool-routed native models; validate locally and submit an upstream dev PR. | ||
|
|
||
| ## Scope and rationale | ||
| Some models are available only to particular accounts. Review automation needs an explicit eligible-account selector without multiplying every model by every account. This feature selects catalog entries; it grants no provider entitlement and promises no change to refusals. | ||
|
|
||
| Reuse existing account namespaces and exact-account routing. Add an optional per-selector model allowlist to settings, extend the existing advanced-settings control, and keep common native rows visible in selective mode. Existing configurations without an allowlist retain their legacy projection until selection is saved. No credentials, routing policy, Daybreak wire normalization, or running service changes. | ||
|
|
||
| ## Plan and audit | ||
| - Configuration validates public selector keys and bare native model IDs; absent means legacy all, empty object means none. | ||
| - GET/PUT settings exposes choices and persists selections with existing rollback and catalog convergence. | ||
| - Catalog consumers filter generated rows by the same allowlist. Selective mode leaves bare rows visible. Entitlement gates and exact-account failures remain unchanged. | ||
| - UI reuses the existing card, toggle, forms and locale files; account/model choices expand beneath the toggle. Quiet developer settings: variance 2, motion 1, density D5. No new visual system. | ||
| - Tests: configuration validation, save/rollback, selected-only catalog and common rows, exact-account regression, UI save/toggle/failure; local typecheck/full tests, GUI checks/build, docs build, privacy scan; independent security/correctness review and browser screenshots before PR. | ||
|
|
||
| Audit: a display allowlist must never become an authorization source. Unknown/deleted selectors must not be advertised. Disabling visibility must not remove routing bindings. Main means current main login, not a permanently pinned email identity. | ||
|
|
||
| User refinement: the original switch keeps its original default/legacy behavior. A second Customize per account toggle opts into selective projection; switching it off restores legacy behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.