ci(service-lifecycle): trigger on release.yml; devlog for the bot-PR toggle - #3269
Merged
Merged
Conversation
added 4 commits
September 2, 2026 19:51
…-lifecycle trigger gap
…gate cannot dead-end release.yml requires a service-lifecycle run for the release SHA when any gated path changed since the previous tag, but a release-branch commit that touched only release.yml (the v2.40.0 permissions carry, #3263/#3264) matched no lifecycle trigger path, so both dispatches needed a manual run. The path is now in both trigger lists and the gate regex; tests/ci-workflows keeps the three in sync.
Contributor
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
the
chore
Owner
Author
|
Owner admin merge, user-authorized (release-train follow-ups). Workflow trigger widening + devlog; ci-workflows 135 pass locally. |
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe Service lifecycle workflow now runs when ChangesRelease lifecycle gating
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 2, 2026
tarunravi
pushed a commit
to tarunravi/opencodex
that referenced
this pull request
Sep 14, 2026
…toggle (lidge-jun#3269) * devlog(release): 080 — bot PR toggle provenance and decision, service-lifecycle trigger gap * chore(devlog): wp1 provenance closeout marker * devlog(release): 080 — toggle applied via REST, read-back true * ci(service-lifecycle): trigger on release.yml changes so the release gate cannot dead-end release.yml requires a service-lifecycle run for the release SHA when any gated path changed since the previous tag, but a release-branch commit that touched only release.yml (the v2.40.0 permissions carry, lidge-jun#3263/lidge-jun#3264) matched no lifecycle trigger path, so both dispatches needed a manual run. The path is now in both trigger lists and the gate regex; tests/ci-workflows keeps the three in sync. --------- Co-authored-by: jun <jun@lidge.dev>
agentHits
pushed a commit
to agentHits/opencodex
that referenced
this pull request
Sep 17, 2026
…toggle (lidge-jun#3269) * devlog(release): 080 — bot PR toggle provenance and decision, service-lifecycle trigger gap * chore(devlog): wp1 provenance closeout marker * devlog(release): 080 — toggle applied via REST, read-back true * ci(service-lifecycle): trigger on release.yml changes so the release gate cannot dead-end release.yml requires a service-lifecycle run for the release SHA when any gated path changed since the previous tag, but a release-branch commit that touched only release.yml (the v2.40.0 permissions carry, lidge-jun#3263/lidge-jun#3264) matched no lifecycle trigger path, so both dispatches needed a manual run. The path is now in both trigger lists and the gate regex; tests/ci-workflows keeps the three in sync. --------- Co-authored-by: jun <jun@lidge.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
service-lifecycle.ymlnow also triggers on.github/workflows/release.yml(push and pull_request), andrelease.yml's service gate regex lists the same path. A release-branch commit that touched onlyrelease.yml([WRONG BRANCH] release: carry the release.yml permissions fix onto main for v2.40.0 #3263/[WRONG BRANCH] release: carry the release.yml permissions fix onto preview for v2.40.0-preview.20260902 #3264 for v2.40.0) produced no lifecycle run, so the gate dead-ended and both dispatches needed a manualworkflow_dispatch.devlog/_plan/260902_windows_ci_release/080_release_automation_followups.md: provenance of the repository toggle "Allow GitHub Actions to create and approve pull requests" (never on — GitHub default, three datedfalsereadings, no disabling commit/devlog/chat), the least-privilege decision, and the applied change via REST (read-backtrue). That toggle is a repository setting, not a file in this PR.Verification
bun test tests/ci-workflows.test.ts135 pass — it pins that the PR and push path lists match and that every push path satisfies the release gate regex.bun run privacy:scangreen.Checklist
Summary by CodeRabbit