Skip to content

test(codex): repair dev by granting the gated 5.6 roster to candidate-scope preview cases - #2570

Merged
lidge-jun merged 1 commit into
devfrom
codex/fix-subagent-fallback-entitlement-roster
Aug 25, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/fix-subagent-fallback-entitlement-roster

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Aug 25, 2026

Copy link
Copy Markdown
Owner

Summary

dev is currently red. #2515 and #2550 were each green in isolation, but their
interaction is semantic: #2550 made gpt-5.6-* account-gated and fails closed when the
entitlement snapshot carries no roster for an account (src/codex/auth-context.ts:463),
while two account-preview cases added by #2515 bind on gpt-5.6-sol without installing a
roster mock. On dev both now throw CodexPoolAuthenticationError: No eligible Codex account supports this model.

This grants those two cases the same roster the neighbouring preview cases already install
(installCodexRosterMock with GPT56_NATIVE_MODELS, the pattern introduced by #2550
itself at lines 732 and 793). Test-only change; no runtime behaviour is modified.

Failing run before the fix: https://github.com/lidge-jun/opencodex/actions/runs/32863008724

Verification

$ bun test tests/subagent-model-fallback.test.ts tests/subagent-fallback-handle-responses.test.ts
 88 pass
 0 fail
 238 expect() calls

Before the change the same command reported 86 pass / 2 fail.

Checklist

  • Targets dev
  • Focused regression run locally
  • No runtime behaviour change (test fixture only)
  • No secrets or account details in the diff

Summary by CodeRabbit

  • Tests
    • Updated subagent fallback pool tests to reflect account eligibility for gated models.
    • Improved test coverage for affinity binding and entitlement handling.

…w cases

#2550 made gpt-5.6-* account-gated and fails closed when the entitlement
snapshot has no roster for an account. Two preview cases added by #2515 bind
on gpt-5.6-sol without installing a roster mock, so on dev they now throw
CodexPoolAuthenticationError. Both PRs were green in isolation; the conflict is
semantic and only appears once both are on dev.

Grants the same roster the neighbouring preview cases already install.
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner August 25, 2026 15:24
@lidge-jun
lidge-jun merged commit 6b08567 into dev Aug 25, 2026
8 of 9 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@lidge-jun
lidge-jun deleted the codex/fix-subagent-fallback-entitlement-roster branch August 25, 2026 15:24
@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Aug 25, 2026
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7c9ddead-8b46-4016-b0b5-fb27eaec9004

📥 Commits

Reviewing files that changed from the base of the PR and between e42778a and 3a5b81e.

📒 Files selected for processing (1)
  • tests/subagent-fallback-handle-responses.test.ts

📝 Walkthrough

Walkthrough

Two subagent fallback tests now install Codex roster mocks that grant GPT56_NATIVE_MODELS to both pool accounts. This keeps account-gated bindings eligible during affinity setup. No production code changed.

Changes

Fallback test entitlement setup

Layer / File(s) Summary
Install roster mocks before fallback binding
tests/subagent-fallback-handle-responses.test.ts
The fallback preview and recovery preview tests grant GPT56_NATIVE_MODELS to pool_acc_a and pool_acc_b before binding affinity. This prevents the account-gated gpt-5.6-sol binding from failing closed with no eligible account. Lines 846–851 and 919–923.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: ingwannu

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-subagent-fallback-entitlement-roster

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lidge-jun
lidge-jun restored the codex/fix-subagent-fallback-entitlement-roster branch August 25, 2026 15:28
@lidge-jun
lidge-jun deleted the codex/fix-subagent-fallback-entitlement-roster branch August 26, 2026 04:12
tarunravi pushed a commit to tarunravi/opencodex that referenced this pull request Sep 14, 2026
…w cases (lidge-jun#2570)

lidge-jun#2550 made gpt-5.6-* account-gated and fails closed when the entitlement
snapshot has no roster for an account. Two preview cases added by lidge-jun#2515 bind
on gpt-5.6-sol without installing a roster mock, so on dev they now throw
CodexPoolAuthenticationError. Both PRs were green in isolation; the conflict is
semantic and only appears once both are on dev.

Grants the same roster the neighbouring preview cases already install.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant