Conversation
olovy
reviewed
Sep 25, 2026
olovy
reviewed
Sep 25, 2026
| var embellishedNonIntegralGraphs = fullEmbellishedGraph.drop(mainGraph.size() + embellishedIntegralGraphs.size()) | ||
| var shapedEmbellishedNonIntegralGraphs = shapeNonIntegralThings(whelk.fresnelUtil, embellishedNonIntegralGraphs) | ||
| var nonIntegralEmbellishments = fullEmbellishedGraph.drop(mainGraph.size() + integralEmbellishments.size()) as List<Map<String, Object>> | ||
| Set<String> visited = integralIds + originalGraph.findResults { (String) it[ID_KEY] } |
Contributor
There was a problem hiding this comment.
shouldn't this be all visited ids in embellished graph? not just intergral
Co-authored-by: Olov Ylinenpää <51744858+olovy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Replaces the previous temporary, hard-coded solution for indexing linked holding data such as library organizations and shelf marks.
The original embellish and framing algorithms are left untouched; similar logic has instead been replicated separately to compensate for data they may drop. We may want to consolidate this in the future.
Indexing performance shouldn't be affected too much, but the index size might grow, since we may now also index some unnecessary data. However, that's now mainly a matter of how the lenses are defined, since we "get what we ask for" -- we should tune those if necessary (probably a good idea regardless).
See also:
libris/definitions#626
libris/lxl_api_tests#54