Define no-language terms alongside ByLang forms - #630
Merged
Merged
Conversation
and move set definitions for same terms from kbv to shared.
olovy
approved these changes
Sep 29, 2026
olovy
left a comment
olovy
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
See comments about set vs not set
Member
Author
|
@olovy Good call! on the non-sets I might also rework this a little (the balance between base, shared and kbv is brittle and should be removed; but until then we may need to keep more of this in shared). |
Member
Author
|
It makes sense to allow for multiple change notes though, but we could revise that separately... 🤔 EDIT: Keeping |
to fix building syscore and ensure terms are shaped and remapped (we aim to move away from this brittle balance). Also remove spuriously added set container declarations for title, prefLabel, and definition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This defines no-language terms alongside our
*ByLangforms and move set definitions for same terms from kbv to shared. Compaction using this fix ensures that no@nonekeys appear in the (*ByLang) language containers, since the JSON-LD compaction algorithm prefers thenulllanguage terms in that case.This should be enough to make data imported using any format (see libris/librisxl#1838) gets compacted to our specific idiomatic form. (Note that framing to embed blanks is a separate step.)