Repository navigation
fix split url format for tftp - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today I approved the lab run for a pull request and every physical job failed at the TFTP download:
Full log can be seen here
This happened after openwrt-tests changed from a plain path (
openwrt_one/) plusexternal_ipto a full URL (tftp://192.168.104.1/openwrt_one/), in "feat: use tftp:// not external_ip" (6efa101d7). That exporter config is now deployed on the FCEFyN lab host. Our strategy passes the staged value to U-Boot unchanged asbootfile, so the DUT asks the server for a file literally namedtftp://....This fix Splits the staged value, now the path becomes
bootfileand the host becomes the server IP. A plain relative path is still accepted, so labs on the old exporter format keep working.TFTP_SERVER_IP(mesh) andexternal_ipstill take precedence over the URL host.openwrt-tests already does this split: https://github.com/aparcar/openwrt-tests/blob/8d5151a5f6991ad597e9faa3c6d28853dda92eab/strategies/tftpstrategy.py#L73
I tested this manually on labgrid-fcefyn:
bananapi_bpi-r4,tests/test_libremesh.py: image downloads and the DUT boots.