Skip to content

fix split url format for tftp - #6

Merged
javierbrk merged 2 commits into
libremesh:mainfrom
javierbrk:fix/tftp-url-bootfile
Nov 17, 2026
Merged

javierbrk merged 2 commits into
libremesh:mainfrom
javierbrk:fix/tftp-url-bootfile

Conversation

@javierbrk

Copy link
Copy Markdown
Member

Today I approved the lab run for a pull request and every physical job failed at the TFTP download:

labgrid.strategy.common.StrategyError: TFTP download failed after 21 attempts (120s): ('dhcp', ['BOOTP broadcast 1', 'DHCP client bound to address 192.168.104.138 (35 ms)', 'Using ethernet@15100000 device', 'TFTP from server 192.168.104.1; our IP address is 192.168.104.138', "Filename 'tftp://192.168.104.1/openwrt_one/firmware-openwrt_one.itb'.", 'Load address: 0x46000000', 'Loading: *\x08', "TFTP error: 'file /srv/tftp/tftp://192.168.104.1/openwrt_one/firmware-openwrt_one.itb not found for 192.168.104.138' (1)", 'Not retrying...'], [])

Full log can be seen here

This happened after openwrt-tests changed from a plain path (openwrt_one/) plus external_ip to a full URL (tftp://192.168.104.1/openwrt_one/), in "feat: use tftp:// not external_ip" (6efa101d7). That exporter config is now deployed on the FCEFyN lab host. Our strategy passes the staged value to U-Boot unchanged as bootfile, so the DUT asks the server for a file literally named tftp://....

This fix Splits the staged value, now the path becomes bootfile and the host becomes the server IP. A plain relative path is still accepted, so labs on the old exporter format keep working. TFTP_SERVER_IP (mesh) and external_ip still take precedence over the URL host.

openwrt-tests already does this split: https://github.com/aparcar/openwrt-tests/blob/8d5151a5f6991ad597e9faa3c6d28853dda92eab/strategies/tftpstrategy.py#L73

I tested this manually on labgrid-fcefyn:

  • Single node, bananapi_bpi-r4, tests/test_libremesh.py: image downloads and the DUT boots.

@javierbrk
javierbrk requested a review from francoriba November 17, 2026 01:40

@francoriba francoriba left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@javierbrk
javierbrk merged commit 640cdb6 into libremesh:main Nov 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants