Repository navigation
fix(results): mask sensitive id values on result cards - #1954
Open
notlakshitha wants to merge 1 commit into
Open
notlakshitha wants to merge 1 commit into
notlakshitha wants to merge 1 commit into
Conversation
ResultCard printed the id field with String(idValue) even when display masking was on, so a national_id (or any *_id) column showed in clear on the phone layout while the table view masked it (libredb#1940).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1940.
ResultCardwas printing the id field withString(idValue)even when display masking was on, so a sensitive id column (e.g.national_id) showed in clear on the phone layout while the table view masked it. Mask the id the same way as the title, and add a regression test.Focused ResultCard tests passed locally (9).