Repository navigation
fix(results-grid): parse the trimmed JSON text in the row detail - #1943
Merged
Merged
Conversation
classifyValue trims a string before it parses it, and trim drops U+00A0, which JSON.parse rejects as a token. A cell holding a JSON container behind a non-breaking space was classified as json, and the row detail then parsed the untrimmed text and threw. The detail now parses the same trimmed text, and a lossy value still keeps its stored text.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The row detail threw for a JSON string that starts or ends with a no-break space.
classifyValuetrims a string before parsing it, andString.prototype.trimremoves U+00A0, so"\u00a0{\"a\":1}"classifies as json.jsonRenderer.renderDetailthen parsed the untrimmed value, andJSON.parsereads U+00A0 as a token, so the detail failed withJSON Parse error: Unrecognized token.renderDetailnow parses the same trimmed textclassifyValueparsed, and the comment that said the parse cannot throw is corrected. A value whose text is not what a re-print would give, such as a 2^53+ integer, still keeps its stored text.The renderer test was written first and failed on main. An independent check tried 14 whitespace characters at the start, end and both sides of 8 bodies: main threw on 132 of them, this branch on none. No non-JSON value classified as json.