Drupal 10 Upgrade - #3
Open
humble-ahitofel wants to merge 6 commits into
Open
Conversation
humble-ahitofel
force-pushed
the
drupal-10-upgrade
branch
2 times, most recently
from
June 7, 2024 10:08
6b74565 to
dc7378c
Compare
- Updated *.info.yml to be compatible with Drupal 10. - Applied code style improvements using Rector for enhanced readability and consistency. - Added explicit array initialization to prevent warnings and ensure proper variable usage. - Standardized constant declarations to follow modern PHP visibility and style conventions. - Replaced deprecated pager_default_initialize() with pager.manager service for pager initialization. - Replaced deprecated drupal_set_message() with \Drupal::messenger() ->addError().
Switched the underlying search engine to RediSearch, removing all references to ElasticSearch.
The current RediSearch PHP interface does not support multisorting. The sorting needs to have a unique value, otherwise, paging behaves strangely. This issue can be fixed when the RediSearch is upgraded from 1.x to 2.x.
humble-ahitofel
force-pushed
the
drupal-10-upgrade
branch
from
June 7, 2024 10:26
dc7378c to
30aae5d
Compare
- Search criteria are always applied to tags. - Stripped the backslash from dashes in result summaries. - Revised the <strong> closing tag; it was not working in all cases. - Restored yearly sorting to the Kirjastot.fi search. - Excluded asklib_question from Kirjastot.fi search.
The current version of RediSearch (7.x) requires only one backslash for escaping characters. All dash characters are escaped later in the KifiBuilder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for review.