feat(hooks): decide AgentTraces state in session_capture - #519
Merged
Merged
Conversation
Keep the stored session state and checkpoint class on one pure match so later capture work does not grow a second kind list in the ingest path. Signed-off-by: Eli Ma <eli@patch.sh>
Contributor
Author
|
Reopen to request the Check, Build and Test workflow. |
v0.23.52 is already published on main, so this card takes the next patch. Signed-off-by: Eli Ma <eli@patch.sh>
# Conflicts: # Cargo.lock # Cargo.toml # docs/development/plan/plan-status.md # install.ps1 # install.sh
# Conflicts: # docs/development/plan/plan-status.md
# Conflicts: # docs/development/plan/plan-status.md
2 tasks
genedna
added a commit
that referenced
this pull request
Sep 23, 2026
Drop --test-threads=1 from Session Capture verification. Mark SCAP-01 remote-pending after PR #519, and open B3-00 now that the runtime.rs mutex is clear. Signed-off-by: Eli Ma <eli@patch.sh>
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session_capture::decideand use it for AgentTracesagent_session.stateand the checkpoint class. TurnEnd still writes a committed checkpoint, SubagentEnd still writes a subagent checkpoint, and a missing repo path still writes none.stopped_atstay in the ingest function. This does not copy Entire's git checkpoint storage.Test plan
cargo +nightly fmt --all --checkcargo clippy --all-targets --all-features -- -D warningssession_capture::tests, TurnEnd checkpoint, SessionEnd checkpoint, SubagentEnd scope checkpointsource .env.test && source .env.live-test && cargo nextest run --all --no-fail-fast --retries 2— 7872 passed, 14 failed. The 14 also fail on baseline0.23.51without this change (umask0002execute-bit checks, and the upgrade-lock hook test). Recorded asDEFER-SCAP-05andDEFER-SCAP-06.base.ymland CodeQL on this headgh release create v0.23.52Made with Cursor