fix(noise): return immediately when reading into an empty buffer#6494
Open
modernzju wants to merge 2 commits into
Open
fix(noise): return immediately when reading into an empty buffer#6494modernzju wants to merge 2 commits into
modernzju wants to merge 2 commits into
Conversation
Signed-off-by: modernzju <modernzju@outlook.com>
Member
|
Hi, and thanks for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates
libp2p-noise'sAsyncReadimplementation to returnPoll::Ready(Ok(0))immediately whenpoll_readis called with an empty destination buffer.Previously, if no decrypted data was already buffered, reading into an empty buffer could still poll the underlying framed stream and return
Pending. Returning immediately matches the expectedAsyncReadbehavior for zero-length reads and avoids unnecessary waiting.AI Assistance Disclosure
Tools used (required — write
noneif no AI was used): e.g. none / Claude Code / Copilot / Cursor / ChatGPTAttestation (required):
Notes & open questions
This does not change the Noise protocol framing or any public API.
It only handles the zero-length read case before polling the underlying stream.
Change checklist