Skip to content

bpftool: Move LLVM functionality into plugin (fixes #262)#264

Open
socketpair wants to merge 1 commit into
libbpf:mainfrom
socketpair:plugin
Open

bpftool: Move LLVM functionality into plugin (fixes #262)#264
socketpair wants to merge 1 commit into
libbpf:mainfrom
socketpair:plugin

Conversation

@socketpair
Copy link
Copy Markdown

No description provided.

Signed-off-by: Korenberg Mark <socketpair@gmail.com>
Comment thread README.md
```console
$ cd bpftool
$ LLVM_CONFIG=../../llvm_build/bin/llvm-config EXTRA_LDFLAGS=-static make -j -C src
$ LLVM_CONFIG=../../llvm_build/bin/llvm-config EXTRA_LDFLAGS=-static LLVM_LINK_STATIC=1 make -j -C src
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need static LLVM plugin ? I mean where libllvm is embeded into the plugin. If no, I can reduce PR.

Comment thread src/jit_disasm.c

static void destroy_context(disasm_ctx_t *ctx)
{
LLVMDisposeMessage(*ctx);
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a wrong function. LLVMDisasmDispose sctually should be used. Fixed in this PR.

Comment thread src/Makefile
$(Q)$(MAKE) -C $(BPF_DIR) OUTPUT=$(LIBBPF_BOOTSTRAP_OUTPUT) clean >/dev/null

prefix ?= /usr/local
libdir ?= $(prefix)/lib
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it OK ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant