ffi: Adapt load_enum to glib 2.87 changes#352
Open
aleasto wants to merge 1 commit into
Open
Conversation
aleasto
force-pushed
the
glib-2.87
branch
2 times, most recently
from
d214e6d to
2f7fc52
Compare
aleasto
changed the title
3v1n0
reviewed
Feb 4, 2026
| local type_class = GObject.TypeClass.ref(gtype) | ||
| local enum_class = core.record.cast( | ||
| type_class, is_flags and GObject.FlagsClass or GObject.EnumClass) | ||
| for i = 0, enum_class.n_values - 1 do |
There was a problem hiding this comment.
Maybe you should do this only for (GLib.MAJOR_VERSION, GLib.MINOR_VERSION) >= (2, 87) (adjusting the syntax)?
Author
There was a problem hiding this comment.
Thanks, I have picked your commit here
There was a problem hiding this comment.
Isn't the logic inverted? We want to use ipairs in the new code, no?
Check version works differently here from what is upstream?
There was a problem hiding this comment.
glib_check_version() returns NULL if version is higher or equal (https://docs.gtk.org/glib/func.check_version.html#return-value), so it seems correct as it is.
GLib 2.87.0 includes a fix (https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4803) to how enum values are handled, causing the value to be read as a Lua table instead of a GLib array. This requires some slightly tweaked code when loading an enum.
robertkirkman
added a commit
to robertkirkman/termux-packages
that referenced
this pull request
Mar 23, 2026
- Fixes termux#26690 - Cherry-pick lgi-devs/lgi#352
robertkirkman
added a commit
to termux/termux-packages
that referenced
this pull request
Mar 23, 2026
- Fixes #26690 - Cherry-pick lgi-devs/lgi#352
termux-pacman-bot
added a commit
to termux-pacman/termux-packages
that referenced
this pull request
Mar 23, 2026
ImL1s
pushed a commit
to ImL1s/termux-packages
that referenced
this pull request
May 1, 2026
- Fixes termux#26690 - Cherry-pick lgi-devs/lgi#352
alexytomi
pushed a commit
to alexytomi/termux-packages
that referenced
this pull request
May 3, 2026
- Fixes termux#26690 - Cherry-pick lgi-devs/lgi#352
|
This patch is now widely adopted, as is glib‑2.88.0. Could you consider merging it or #361? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After glib change https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4803,
the
valuesfield is bound as an array with typetablerather thanrecord.We can iterate over the array with ipairs().